Repository navigation
Conversation
Zephyr's img_mgmt answers command 6 with the images and slots the application can see (CONFIG_MCUMGR_GRP_IMG_SLOT_INFO). Wrap smp's ImageSlotInfoReadRequest like the other image requests. Assisted-by: Claude:claude-opus-5-5
mniestroj
force-pushed
the
feat/image-slot-info
branch
from
October 24, 2026 10:15
a3ef9fc to
9ceb436
Compare
ImageSlotInfoRead needs smp's slot info models, which no smp release has yet. Take smp from that pull request's commit, so that CI can run. This is temporary: drop it once an smp release has the models, and raise the smp floor to that release instead. cbor2 moves to 6, which smp has required since 4.2.0. Assisted-by: Claude:claude-opus-5-5
mniestroj
force-pushed
the
feat/image-slot-info
branch
from
October 24, 2026 13:31
9ceb436 to
9c173ce
Compare
mniestroj
added a commit
to mniestroj/smpmgr
that referenced
this pull request
Oct 24, 2026
`image slot-info` needs ImageSlotInfoRead from intercreate/smpclient#145, which in turn needs the slot info models from JPHutchins/smp#75. Neither is released yet, so take both from those pull requests' commits, so that CI can run. This is temporary: once both are released, drop it and move the smpclient pin to the release. smp is named here only because Poetry would otherwise take it from PyPI, where no release has slot info yet. cbor2 moves to 6, which smp has required since 4.2.0. Assisted-by: Claude:claude-opus-5-5
Collaborator
|
Warning LLM Disclosure This post was authored by claude-opus-5-5 on behalf of @JPHutchins. JP asked me to post the handoff plan for the related smp change (JPHutchins/smp#76, which took over JPHutchins/smp#74) here. Related smp change: JPHutchins/smp#76 (supersedes JPHutchins/smp#74) adds a separate request/response pair for MCUboot's mode query. smpclient needs one new request to reach it. Nothing in smpclient breaks. Handoff plan
Details for the follow-up# src/smpclient/requests/os_management.py
class MCUbootModeRead(smpos.MCUbootModeReadRequest, _OSGroupBase):
_Response = smpos.MCUbootModeReadResponse# tests/test_requests.py
(
smpos.MCUbootModeReadRequest(query="mode"),
MCUbootModeRead(query="mode"),
smpos.MCUbootModeReadResponse,
smpos.OSManagementErrorV1,
smpos.OSManagementErrorV2,
),
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zephyr's img_mgmt answers command 6 with the images and slots the application can see (CONFIG_MCUMGR_GRP_IMG_SLOT_INFO). Wrap smp's ImageSlotInfoReadRequest like the other image requests.