Repository navigation
[Repo Assist] test: re-enable Go-to-implementation-on-interface-definition test - #1506
Merged
Krzysztof-Cieslak merged 2 commits intoMar 18, 2026
Conversation
…oses #986) The test was disabled (ptestCaseAsync) with TODO comments. Root cause: the match pattern was wrong — the server returns U2.C1(U2.C2 locations) for multiple results (Location[]) but the test checked for U2.C2 at the top level (which would be LocationLink[]). Fix: - Change ptestCaseAsync -> testCaseAsync to re-enable the test - Fix match pattern to properly unwrap U2.C1(U2.C2 ...) - Add assertions: >=2 results, all in Library.fs - Remove stale TODO comments and incorrect range assertions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Closes #986.
Problem
The
Go-to-implementation-on-interface-definitiontest was disabled withptestCaseAsync(skipped) since PR #977, with TODO comments and commented-out range assertions. The root cause of the original disabling was a bug in the test's match pattern: the server returnsU2.C1(U2.C2 locations)for multipleLocation[]results, but the test matched againstU2.C2at the top level — which would only matchLocationLink[]responses. This caused the test to always hitU2.C1 _res -> failtest "Should be multiple GotoResult"and fail.Fix
ptestCaseAsync→testCaseAsyncto re-enable the testU2.C1(U2.C2 res)for a multiple-location responseLibrary.fsTrade-offs
The new assertions validate the essential behaviour (the feature works and returns implementations from the right file) without over-specifying exact byte offsets, which makes the test more resilient to minor FCS range changes.
Test Status
Build succeeded. GoTo test suite ran and the previously-skipped test now passes (38 passed, 2 unrelated infrastructure timeouts on network-dependent sourcelink tests, 4 C#-dependency skips).