This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Repository navigation
feat: new IPLD Format API - #51
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
- Coverage 92.3% 84.55% -7.76%
==========================================
Files 7 7
Lines 325 259 -66
==========================================
- Hits 300 219 -81
- Misses 25 40 +15
Continue to review full report at Codecov.
|
magik6k
approved these changes
Apr 24, 2019
rvagg
approved these changes
May 1, 2019
| } | ||
|
|
||
| setImmediate(() => callback(null, res)) | ||
| visibility.removeEnumerableProperties(res, ['gitType']) |
Member
There was a problem hiding this comment.
There are only 2 uses of visibility and they both have this one property, they (and visibility.js) could be replaced with Object.defineProperty(res, 'gitType', { enumerable: false }). I'll leave that call up to you though, I think you know my thoughts on the defineProperty() use and the re-use of visibility.js across the projects.
BREAKING CHANGE: The API is now async/await based There are numerous changes, the most significant one is that the API is no longer callback based, but it using async/await. For the full new API please see the [IPLD Formats spec]. [IPLD Formats spec]: https://github.com/ipld/interface-ipld-format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The API is now async/await based
There are numerous changes, the most significant one is that the API
is no longer callback based, but it using async/await.
For the full new API please see the IPLD Formats spec.