Repository navigation
Conversation
…ample projects, build-time zips and versions - Add shared wizard infrastructure in com.jme3.gde.templates.shared: AbstractProjectWizardIterator (wizard plumbing), ProjectWizardPanel(Visual) (name/location step shared by all templates), ZipUtils (single-root-dir aware unzip), TemplateVersions (reads filtered version.properties) - Replace the copy-pasted MonkeyZone/JaimesAscent download wizards with a data-driven SampleProjectWizardIterator configured by SampleProjectConfig; each template is now a ~15 line factory class - Download sample projects asynchronously with timeouts, cache per project name, and block 'Next' until the download succeeded - Detect the zip's top-level directory dynamically instead of hardcoding it (fixes Jaimes Ascent v1.1.3 landing in a nested folder) - Downloaded sample projects keep their upstream build.gradle (it contains custom tasks); only settings.gradle's project name is rewritten - Single source of truth for versions: gradle.properties feeds version.properties via the ant -filter-template-versions target, and the FreeMarker templates get javaVersion/gradleVersion/jmeVersion from TemplateVersions at runtime - Generate GradleDesktopGameProject.zip and RollingTheMonkeyProject.zip at build time from new GradleDesktopGameTemplate/ and RollingTheMonkeyTemplate/ source folders; remove stale checked-in zips (they contained contradictory build files) - Fix layer.xml: Monkey Zone pointed at the Rolling The Monkey zip, Jaimes Ascent at a non-existent zip, and there were two 'Project' folders - Declare the org.netbeans.libs.freemarker module dependency explicitly - GradleDesktopGameWizardIterator defaults the jme version to the SDK version
…ule dependency The org.netbeans.libs.freemarker module has no public packages in NetBeans 31, so it cannot be compiled against. The code only uses javax.script.* (JDK classes) and resolves the FreeMarker ScriptEngine at runtime via ScriptEngineManager. - Remove the compile-time module dependency from project.xml - Add OpenIDE-Module-Module-Dependencies to manifest.mf for runtime availability Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
… project folder 1. ProjectWizardPanelVisual: add jme-logo image on the left, fix GroupLayout so components no longer overlap, and cap the panel at 64px max height. 2. ZipUtils: filter nbproject/project.xml during extraction to replace the <name> element with the actual project folder name, so the BasicGame (Ant) template is recognised as a valid NetBeans project after extraction. 3. ProjectWizardPanelVisual.read(): always default the project location to ProjectChooser.getProjectsFolder() when no previous location is set, falling back to the user's home directory. Also fix the freemarker compile dependency that was never actually removed from project.xml (it was still present in the committed version). Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
… override The previous fix put OpenIDE-Module-Module-Dependencies in manifest.mf, but the harness generates this attribute from project.xml during the build and the manual manifest entry REPLACED all auto-generated dependencies (including org.openide.dialogs), causing ClassNotFoundException for WizardDescriptor at runtime. Fix: - Remove the manual OpenIDE-Module-Module-Dependencies from manifest.mf (the harness will generate it correctly from project.xml) - Add org.netbeans.libs.freemarker as a runtime-only dependency in project.xml (no build-prerequisite/compile-dependency, since the module has no public packages in NetBeans 31 and cannot be compiled against) The generated manifest now correctly includes ALL module dependencies: com.google.gson, org.netbeans.libs.freemarker, com.jme3.gde.project.baselibs, com.jme3.gde.project.libraries, org.netbeans.api.templates, org.netbeans.modules.projectapi, org.netbeans.modules.projectuiapi, org.netbeans.spi.palette, org.openide.awt, org.openide.dialogs, org.openide.filesystems, org.openide.filesystems.nb, org.openide.loaders, org.openide.util, org.openide.util.lookup, org.openide.util.ui Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
… name 1. layer.xml: MonkeyZone and JaimesAscent no longer reference missing MonkeyZone.zip / JaimesAscent.zip files. They now point to RollingTheMonkeyProject.zip as a placeholder template file (the actual project is downloaded at runtime by SampleProjectWizardIterator). The url attribute is required by NetBeans for template registration. 2. SampleProjectDownloadPanelVisual: add a bold nameLabel next to the icon so the project name appears beside the image instead of overlapping it. Both are top-aligned in a horizontal group. The download button, text area, and status field are now in a separate column to the right. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
… single-panel templates The shared ProjectWizardPanel had isFinishPanel() returning false (copied from multi-panel templates like GradleDesktopGame which has additional panels after the name/location step). For single-panel templates (BasicGame, RollingTheMonkey, and sample projects like MonkeyZone/JaimesAscent), this caused the wizard to show 'Next' instead of 'Finish', and after instantiate() created the project folder, the wizard re-validated and found the folder already existed (since dirF.mkdirs() created it), showing the error 'Project Folder already exists and is not empty.' Fix: Add a finishPanel constructor parameter to ProjectWizardPanel. Single-panel templates (BasicGame, RollingTheMonkey, SampleProject) pass true; multi-panel templates (GradleDesktopGame) keep the default false. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
…ndle - AbstractProjectWizardIterator.createFileFromTemplate: FileUtil.toFileObject() returns null for the generated settings.gradle/build.gradle because the template zips no longer ship them, causing an NPE on Finish. Create the target file via FileUtil.createData() when it does not exist yet. - Add Bundle.properties to the shared.sample package: NbBundle resolves the bundle from the calling class's package, so the keys used by SampleProjectDownloadPanel(Visual) and the "LBL_DownloadProjectStep" step name must live in com.jme3.gde.templates.shared.sample.Bundle, not in the shared package bundle. This fixes the MissingResourceException when stepping through the MonkeyZone/JaimesAscent sample wizards. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Contributor
Author
|
@jaime-jmebot ahoy. can you review this as well? thanks |
jaime-jmebot
reviewed
Nov 1, 2026
| public static void unZipFile(InputStream source, FileObject projectRoot) throws IOException { | ||
| byte[] content = source.readAllBytes(); | ||
| List<ZipEntry> entries = new ArrayList<>(); | ||
| try (ZipInputStream str = new ZipInputStream(new ByteArrayInputStream(content))) { |
There was a problem hiding this comment.
The single-root handling here assumes every archive entry has a slash after its top-level name, but GitHub source archives commonly include the explicit top-level directory entry itself (for example, repo-tag/). For that entry indexOf('/') is the final character, so detection returns repo-tag/; the later strip then produces an empty entry name and attempts createFolder(projectRoot, ""), which can fail and abort extraction. Could you ignore a directory entry whose name is exactly the candidate root when detecting/stripping the prefix, and skip it during extraction? That would keep normal GitHub archives usable while still stripping their root.
jaime-jmebot
suggested changes
Nov 1, 2026
jaime-jmebot
left a comment
There was a problem hiding this comment.
Hi neph1, thanks for taking on this substantial cleanup. The shared wizard and sample-project abstractions make the template code much easier to maintain, and centralizing the generated-project versions is a nice improvement. I reviewed the changed wizard paths, the shared archive extraction code, and the build-time zip/version wiring.
I found one issue in the new common extraction path: GitHub-generated source archives include an explicit top-level directory entry in addition to their files. The current root-prefix detection treats that entry as an ordinary path, and stripping it can leave an empty entry name and fail project creation. I left an inline comment on ZipUtils with the scenario and suggested behavior; fixing this is important because it affects every sample project downloaded through the shared wizard.
The rest of the refactor reads coherently, and it’s especially good to have the archive and wizard plumbing implemented once rather than duplicated across templates. Once the root-directory entry is handled, please rerun the sample-template creation flow against a normal GitHub source archive to verify extraction proceeds all the way through. Thanks again for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the jME3 SDK project template system in
jme3-templates/src/com/jme3/gde/templates:AbstractProjectWizardIterator,ProjectWizardPanel,ProjectWizardPanelVisual) replace ~10 near-identical per-template copies, cutting ~1900 lines of duplicated panel/iterator code.SampleProjectConfig+SampleProjectWizardIterator+SampleProjectDownloadPaneldescribe each sample (MonkeyZone, Jaime's Ascent, Rolling the Monkey) declaratively instead of requiring a full wizard iterator + panel + download panel per sample.GradleDesktopGameProject.zip,RollingTheMonkeyProject.zip) are now generated at build time from theGradleDesktopGameTemplate/andRollingTheMonkeyTemplate/source directories viaZipUtils, instead of being checked in as binary blobs that go stale when Java/Gradle versions change.TemplateVersions+version.propertieshold the Java/Gradle/jME versions in one place, consumed by the FreeMarkerbuild.gradle.ftltemplates and the zip build.build.xml: the ant build now delegates zip creation to the Java helper and reads versions fromversion.properties.jaimesascent/build.gradle.ftlandmonkeyzone/build.gradle.ftl(sample projects are downloaded as zips, not generated).layer.xmlto register the simplified template wizards.Net effect: ~2400 lines added, ~4300 lines removed.
Verification
git diff master...vibe/simplify-templates-59edb5 --stat— 78 files changed, 2362 insertions(+), 4295 deletions(-)neph1/sdk:vibe/simplify-templates-59edb5Notes
.ziptemplate files are deleted; they are regenerated byant(seebuild.xmltargetbuild-template-zips).gradle.propertiesgainstemplateJavaVersion,templateGradleVersion,templateJmeVersion.jme3-templates/src/com/jme3/gde/templates/version.propertiesis the single source of truth for template versions.