Skip to content

Do not fail silently if IP in connection window is invalid #1945

Open

Description

@ann0see

Follow up #1938 by @softins

If an invalid IP is entered, the connection window closes after clicking on connect and Jamulus does not give an error message.

Proposed behaviour:

  1. Check IP/Domain on entry and give a red warning "The IP you entered is invalid. Make sure you enter it in a correct format"
  2. Same as above, but after clicking on connect as error message

Activity

  1. gilgongo commented on Nov 7, 2021

    @gilgongo
    Member

    It's really a bug, so I'll flag for next release in hope.

  2. added this to the Release 3.9.0 milestone on Nov 7, 2021
  3. pljones commented on Nov 7, 2021

    @pljones
    Collaborator

    #1938 is rather long. Was there any particular comment?

    By "Invalid", does this mean "Syntactically incorrect", rather than "Cannot connect to a Jamulus server at that address"?

    If it's the former, it should be before closing the Connect dialog. If it's the latter, the existing warning banner should suffice.

  4. gilgongo commented on Nov 7, 2021

    @gilgongo
    Member

    @pljones I think invalid as in syntactically incorrect (so 192.168.o.10, and hopefully also a DNS address that doesn't resolve) as the message is "Make sure you enter it in a correct format". Should probably be "The address you entered is invalid..." I think.

  5. pljones commented on Nov 7, 2021

    @pljones
    Collaborator

    Yes. (Ugh, took a while to read your message correctly...)

    It's got to cope with non-IP addresses, of course. "I0.10.123.I0" is a perfectly valid address syntactically (it probably doesn't resolve, so you won't connect to anything).

    The easiest check is to do just that - attempt to resolve the input text to an IP address (with optional port).

    If it fails, you error: "The address entered is not valid. Make sure you typed it correctly."

    If it works, you exit the Connect dialog and proceed to attempting to communicate with the provided network address.

  6. removed this from the Release 3.9.0 milestone on Jun 14, 2022
  7. ann0see commented on Jun 14, 2022

    @ann0see
    MemberAuthor

    De-Tagged. I think it’s a thing for the backlog

  8. added
    bugSomething isn't working
    and removed on Aug 12, 2023
  9. pljones commented on Aug 12, 2023

    @pljones
    Collaborator

    I'm going to put this on the 3.11.0 backlog as it shouldn't be too hard.

  10. moved this from Triage to Backlog in Trackingon Aug 12, 2023
  11. added this to the Release 3.11.0 milestone on Aug 12, 2023
  12. ann0see commented on Aug 12, 2023

    @ann0see
    MemberAuthor

    Probably we can check with a regular expression. I still believe the problem lies deeper: what if we enter an which doesn't have a Jamulus server running?
    But maybe that's already handled correctly with a timeout.

  13. moved this from Backlog to Triage in Trackingon Sep 27, 2023
  14. ann0see commented on Sep 22, 2024

    @ann0see
    MemberAuthor

    I believe #3372 may fix this as side effect - to some extent at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    • Status
      Triage

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions