You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Do not fail silently if IP in connection window is invalid #1945
@pljones I think invalid as in syntactically incorrect (so 192.168.o.10, and hopefully also a DNS address that doesn't resolve) as the message is "Make sure you enter it in a correct format". Should probably be "The address you entered is invalid..." I think.
Yes. (Ugh, took a while to read your message correctly...)
It's got to cope with non-IP addresses, of course. "I0.10.123.I0" is a perfectly valid address syntactically (it probably doesn't resolve, so you won't connect to anything).
The easiest check is to do just that - attempt to resolve the input text to an IP address (with optional port).
If it fails, you error: "The address entered is not valid. Make sure you typed it correctly."
If it works, you exit the Connect dialog and proceed to attempting to communicate with the provided network address.
Probably we can check with a regular expression. I still believe the problem lies deeper: what if we enter an which doesn't have a Jamulus server running?
But maybe that's already handled correctly with a timeout.
Activity
gilgongo commentedon Nov 7, 2021
It's really a bug, so I'll flag for next release in hope.
pljones commentedon Nov 7, 2021
#1938 is rather long. Was there any particular comment?
By "Invalid", does this mean "Syntactically incorrect", rather than "Cannot connect to a Jamulus server at that address"?
If it's the former, it should be before closing the Connect dialog. If it's the latter, the existing warning banner should suffice.
gilgongo commentedon Nov 7, 2021
@pljones I think invalid as in syntactically incorrect (so 192.168.o.10, and hopefully also a DNS address that doesn't resolve) as the message is "Make sure you enter it in a correct format". Should probably be "The address you entered is invalid..." I think.
pljones commentedon Nov 7, 2021
Yes. (Ugh, took a while to read your message correctly...)
It's got to cope with non-IP addresses, of course. "I0.10.123.I0" is a perfectly valid address syntactically (it probably doesn't resolve, so you won't connect to anything).
The easiest check is to do just that - attempt to resolve the input text to an IP address (with optional port).
If it fails, you error: "The address entered is not valid. Make sure you typed it correctly."
If it works, you exit the Connect dialog and proceed to attempting to communicate with the provided network address.
ann0see commentedon Jun 14, 2022
De-Tagged. I think it’s a thing for the backlog
pljones commentedon Aug 12, 2023
I'm going to put this on the 3.11.0 backlog as it shouldn't be too hard.
ann0see commentedon Aug 12, 2023
Probably we can check with a regular expression. I still believe the problem lies deeper: what if we enter an which doesn't have a Jamulus server running?
But maybe that's already handled correctly with a timeout.
ann0see commentedon Sep 22, 2024
I believe #3372 may fix this as side effect - to some extent at least.