Skip to content

Add missing override specifiers - #3888

Merged
softins merged 1 commit into
jamulussoftware:mainfrom
softins:add-missing-overrides
Aug 11, 2026
Merged

softins merged 1 commit into
jamulussoftware:mainfrom
softins:add-missing-overrides

Conversation

@softins

@softins softins commented Aug 10, 2026 •

Copy link
Copy Markdown
Member

Short description of changes

Add missing override specifiers to satisfy compiler warnings on macOS

CHANGELOG: Added missing override specifiers for virtual methods

Context: Fixes an issue?

This is similar to #3667. A couple of new ones showed up while compiling on macOS. I think they surfaced
due to adding the event filter in #3859, which was itself an override.

This change adds the missing override specifiers, but does not change any functionality.

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready

What is missing until this pull request can be merged?

Nothing

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Satisfies compiler warnings on macOS
@softins softins added this to the Release 4.0.0 milestone Aug 10, 2026
@softins softins self-assigned this Aug 10, 2026
@softins softins added the refactoring Non-behavioural changes, Code cleanup label Aug 10, 2026
@softins softins added this to Tracking Aug 10, 2026
@github-project-automation github-project-automation Bot moved this to Triage in Tracking Aug 10, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Waiting on Team in Tracking Aug 11, 2026
@softins
softins merged commit c469da9 into jamulussoftware:main Aug 11, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting on Team to Done in Tracking Aug 11, 2026
@softins
softins deleted the add-missing-overrides branch August 11, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Non-behavioural changes, Code cleanup

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants