Found while working on #274.
Evidence
test/test_tls.py:16 uses pytest.yield_fixture:
@pytest.yield_fixture(scope="module", autouse=True)
def memcached_tls():
pytest.yield_fixture is a deprecated alias of @pytest.fixture. The suite
prints one PytestDeprecationWarning for it on every run.
#274 replaced the four uses in test/conftest.py. It did not touch
test/test_tls.py, because that file is outside its stated scope.
Scope
One line. Replace @pytest.yield_fixture with @pytest.fixture.
Consider whether test/test_tls.py should also use the shared
_wait_until_accepting helper that #274 added to test/conftest.py. It holds
its own time.sleep(0.1) and its own p.poll() check today.
Acceptance criteria
Order
Do #274 first. It adds the helper this issue can reuse.
Found while working on #274.
Evidence
test/test_tls.py:16usespytest.yield_fixture:pytest.yield_fixtureis a deprecated alias of@pytest.fixture. The suiteprints one
PytestDeprecationWarningfor it on every run.#274 replaced the four uses in
test/conftest.py. It did not touchtest/test_tls.py, because that file is outside its stated scope.Scope
One line. Replace
@pytest.yield_fixturewith@pytest.fixture.Consider whether
test/test_tls.pyshould also use the shared_wait_until_acceptinghelper that #274 added totest/conftest.py. It holdsits own
time.sleep(0.1)and its ownp.poll()check today.Acceptance criteria
test/test_tls.pyuses@pytest.fixture.pytest -qprints noPytestDeprecationWarning.TLS support.
Order
Do #274 first. It adds the helper this issue can reuse.