Conversation
Signed-off-by: Elias Assaf <elyas51000@gmail.com>
|
I will continue checking if it works with the editors defined in editPreset. please give feedback if something like this is desired to continue with the MR and adding tests etc |
2d8f345 to
564b579
Compare
No, I don't take PRs here any more, see CONTRIBUTING.md. I like the idea though, and can put it on my todo list. I suspect this needs a bit more work than the changes you made here. I'll look into this when time allows, but it will probably not be soon. In the meantime, a good enough workaround could be a custom command; the only downside is that it would have a different keybinding. |
Np, just looked at from testing more editors it seems that not all of them support this, like nano and micro, and other like vscode have "undesired" behavior of opening a new editor instance, so I agree it will take more thought to implement this correctly. Will try the custom keybind approach, thanks for the suggestion |
PR Description
Hi, when im editing files in some editor, sometimes I want to open the directory of where some changed file exists, I usually open the file then go to directory view in my editor, this isn't the best user experience if the file is large as it takes time to load it or it is a binary file, when we try to edit the directory directly we get an error that we cannot edit a directory, but that is not the case for most editors
this commit removes the check that blocks hitting 'e' in files tab to edit a directory, and adds a call to edit the selected directories according to the config of editPreset.
It was tested on the following presets:
Please check if the PR fulfills these requirements
go generate ./...)