Repository navigation
ci: remove dead nix-version matrix from cli-tests test job - #2880
Merged
Merged
Conversation
The `test` job defined a 3-value `nix-version` matrix, but the value was never wired into any step after the job switched to installing Nix via devbox-install-action (which can't pin a Nix version). The three legs ran identical duplicates, tripling the slowest/flakiest job for no extra coverage. Remove the matrix and document how to re-add it once the install action supports specifying a Nix version. Cross-version coverage remains in the separate test-nix-versions job. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused nix-version matrix from the cli-tests workflow job to eliminate duplicate CI legs now that Nix is installed via devbox-install-action, which (per the inline note) does not support pinning a specific Nix version. Cross-version Nix coverage remains handled by the separate test-nix-versions job in the same workflow.
Changes:
- Removed the
nix-versionmatrix from thetest(cli tests) job to avoid redundant runs. - Added an explanatory inline comment documenting why the matrix was removed and when to re-introduce it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from
mikeland73/fix-flaky-cicd-tests(3/5).The
cli-testsjob ran anix-versionmatrix, but thedevbox-install-actionwe now use to install Nix doesn't let us pin a specific Nix version, so all matrix legs ran identical duplicates (3× the jobs, 3× the flake surface, no extra coverage). Removed. Cross-version coverage is still provided by the separatetest-nix-versionsjob.🤖 Generated with Claude Code