Repository navigation
XRAY-144809 - CA command [Maven]: Add option to consider plugin deps - #771
Conversation
cda523a to
61a0c42
Compare
61a0c42 to
93373e9
Compare
93373e9 to
086f4ce
Compare
086f4ce to
5e9df69
Compare
5e9df69 to
1eaaa16
Compare
|
I have read the CLA Document and I hereby sign the CLA |
attiasas
left a comment
There was a problem hiding this comment.
Nice job!
Please add an integration test case with a project replicating that.
I would consider also adding this option to jf audit command. most of the logic is the same, users may want to include this in their scan as well
|
Also, why this is not implemented in |
|
This is needed by a customer, we have consider it to take as a long term solution in https://github.com/jfrog/maven-dep-tree in upcoming quarter |
|
Keeping it for curation scope for this PR , will connect with audit team to discuss enabling for their workflow |
1eaaa16 to
11f8efd
Compare
|
Added an integration test case maven tree - one blocked plugin dependency in TestDoCurationAudit (commands/curation/curationaudit_test.go), with a new fixture under tests/testdata/projects/package-managers/maven/maven-curation-plugin-deps/. What it tests (real mvn run against the mock curation server): jf ca --mvn-include-plugin-deps detects a curation-blocked artifact that only enters the build via a Maven build plugin's transitive closure — the exact "0 blocked in jf ca but build is blocked" scenario. |
…include-mvn-plugins # Conflicts: # commands/curation/curationaudit.go # sca/bom/buildinfo/technologies/common.go
Should be documented that this is a "temp" fix. I whould rather you add it to the actual maven-dep-tree repo and we will add this only if its urgent until actually implemented. should be documented and tracked |
|
This is needed by a customer, we have consider it to take as a long term solution in https://github.com/jfrog/maven-dep-tree in upcoming quarter - https://jfrog-int.atlassian.net/browse/XRAY-145307 |
attiasas
left a comment
There was a problem hiding this comment.
LGTM for now. pending to see logic moved to maven-dep-tree
jfrog-cli 2.108.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What changed in v2.108.0 > Auto-generated from 6 repositories · 2026-06-11 > Comparing `v2.107.0` → `v2.108.0` > ℹ️ No changes in: gofrog ### ✨ New Features - **[build-info-go]** Added pnpm package support to recognise 403 Forbidden output [#389](jfrog/build-info-go#389) (@Phavya-jfrog) - **[jfrog-cli]** Add jf mcp command to configure the remote JFrog MCP server [#3533](jfrog/jfrog-cli#3533) (@ehl-jf) - **[jfrog-cli]** Add AI context description to commands [#3503](jfrog/jfrog-cli#3503) (@ehl-jf) - **[jfrog-cli]** feat: add server id to login command [#3394](jfrog/jfrog-cli#3394) (@tim-goto) - **[jfrog-cli]** RTECO-1021 - Enhance metrics visibility by including package manager context [#3534](jfrog/jfrog-cli#3534) (@fluxxBot) - **[jfrog-cli]** Make nix command visible [#3539](jfrog/jfrog-cli#3539) (@reshmifrog) - **[jfrog-cli]** Added Post Failure Run support for pnpm and Yarn [#3509](jfrog/jfrog-cli#3509) (@Phavya-jfrog) - **[jfrog-cli-artifactory]** JGC-473 - Add AI-agent help text to artifactory commands [#455](jfrog/jfrog-cli-artifactory#455) (@ehl-jf) - **[jfrog-cli-artifactory]** RTECO-1021 - Enhance metrics visibility by including package manager context [#481](jfrog/jfrog-cli-artifactory#481) (@fluxxBot) - **[jfrog-cli-artifactory]** RTECO-1400 - Add path validation to prevent traversal attacks in artifact handling [#487](jfrog/jfrog-cli-artifactory#487) (@fluxxBot) - **[jfrog-cli-core]** RTECO-1021 - Enhance metrics visibility by including package manager context [#1569](jfrog/jfrog-cli-core#1569) (@fluxxBot) - **[jfrog-cli-security]** Support parsing SCA issues without components [#758](jfrog/jfrog-cli-security#758) (@attiasas) - **[jfrog-cli-security]** JGC-473 - Add AI-agent help text to security commands [#760](jfrog/jfrog-cli-security#760) (@ehl-jf) - **[jfrog-cli-security]** Feature/xray 138688 add yarn support for jf ca [#759](jfrog/jfrog-cli-security#759) (@gauriy-tech) - **[jfrog-cli-security]** XRAY-144809 - CA command [Maven]: Add option to consider plugin deps [#771](jfrog/jfrog-cli-security#771) (@gauriy-tech) - **[jfrog-cli-security]** Feature/xray 138688 add pnpm support for jf ca [#769](jfrog/jfrog-cli-security#769) (@gauriy-tech) ### 🐛 Bug Fixes - **[build-info-go]** RTECO-1287 jf poetry install --only main captures all dependency [#391](jfrog/build-info-go#391) (@reshmifrog) - **[jfrog-cli]** RTECO 1296 fix repeated 401 errors before fallback authentication [#3537](jfrog/jfrog-cli#3537) (@reshmifrog) - **[jfrog-cli]** RTECO-1287 jf poetry install --only main captures all dependency [#3530](jfrog/jfrog-cli#3530) (@reshmifrog) - **[jfrog-cli-artifactory]** Updated logic for extracting repository key in case of reverse proxy scenario [#458](jfrog/jfrog-cli-artifactory#458) (@naveenku-jfrog) - **[jfrog-cli-core]** Revert "Fix reference token privilege escalation" [#1571](jfrog/jfrog-cli-core#1571) (@reshmifrog) - **[jfrog-cli-security]** XRAY-140212 - Updated gradle dep tree jar with the missing deps fix [#751](jfrog/jfrog-cli-security#751) (@gauriy-tech) - **[jfrog-cli-security]** fix: disable npm workspaces for native config reads [#762](jfrog/jfrog-cli-security#762) (@omribz156) ### 📦 Other Changes - **[build-info-go]** RTECO-1365 Include e2e tests from jfrog cli to build-info-go [#390](jfrog/build-info-go#390) (@reshmifrog) - **[jfrog-cli-artifactory]** pnpm update error output handling [#465](jfrog/jfrog-cli-artifactory#465) (@Phavya-jfrog) - **[jfrog-cli-security]** Auto install Cocoapods when Podfile.lock not exist [#723](jfrog/jfrog-cli-security#723) (@attiasas) - **[jfrog-client-go]** Use Windows system certificate store for CLI TLS transport [#1351](jfrog/jfrog-client-go#1351) (@RemiBou) --- ### 📊 Summary | Repository | Changes | |---|---| | [jfrog-cli](https://github.com/jfrog/jfrog-cli) | 8 | | [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | 8 | | [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | 5 | | [build-info-go](https://github.com/jfrog/build-info-go) | 3 | | [jfrog-cli-core](https://github.com/jfrog/jfrog-cli-core) | 2 | | [jfrog-client-go](https://github.com/jfrog/jfrog-client-go) | 1 | | **Total** | **27** | ### 🔗 Module Version Changes | Module | From | To | |---|---|---| | [build-info-go](https://github.com/jfrog/build-info-go) | `v1.13.1-0.20260528065004-80409c046540` | `v1.13.1-0.20260610071651-260ad6720e0d` | | [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | `v0.8.1-0.20260603105750-3886c0f01286` | `v0.8.1-0.20260610074911-82ce7d90edbd` | | [jfrog-cli-core](https://github.com/jfrog/jfrog-cli-core) | `v2.60.1-0.20260601130310-8d52a530da18` | `v2.60.1-0.20260609101026-df3091b39d06` | | [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | `v1.29.3` | `v1.30.0` | | [jfrog-client-go](https://github.com/jfrog/jfrog-client-go) | `v1.55.1-0.20260528115006-6ca9682a3255` | `v1.55.1-0.20260603130552-af1dd449b994` | </pre> <p>View the full release notes at <a href="https://github.com/jfrog/jfrog-cli/releases/tag/v2.108.0">https://github.com/jfrog/jfrog-cli/releases/tag/v2.108.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!11303
devbranch.go vet ./....go fmt ./....Full details about the RCA and Fix is described here https://jfrog-int.atlassian.net/browse/XRAY-144809?focusedCommentId=1115010
After Fix


Before Fix
