Skip to content

XRAY-144809 - CA command [Maven]: Add option to consider plugin deps - #771

Merged
attiasas merged 3 commits into
jfrog:devfrom
gauriy-tech:feature/XRAY-144809-include-mvn-plugins
Jun 9, 2026
Merged

attiasas merged 3 commits into
jfrog:devfrom
gauriy-tech:feature/XRAY-144809-include-mvn-plugins

Conversation

@gauriy-tech

@gauriy-tech gauriy-tech commented Jun 1, 2026 •

Copy link
Copy Markdown
Collaborator
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Full details about the RCA and Fix is described here https://jfrog-int.atlassian.net/browse/XRAY-144809?focusedCommentId=1115010

After Fix
Screenshot 2026-06-01 at 10 40 30 PM
Screenshot 2026-06-01 at 10 58 21 PM

Before Fix
Before_Fix

@gauriy-tech
gauriy-tech force-pushed the feature/XRAY-144809-include-mvn-plugins branch from cda523a to 61a0c42 Compare June 1, 2026 05:20
@gauriy-tech
gauriy-tech force-pushed the feature/XRAY-144809-include-mvn-plugins branch from 61a0c42 to 93373e9 Compare June 2, 2026 05:34
@gauriy-tech
gauriy-tech force-pushed the feature/XRAY-144809-include-mvn-plugins branch from 93373e9 to 086f4ce Compare June 8, 2026 04:52
@gauriy-tech
gauriy-tech force-pushed the feature/XRAY-144809-include-mvn-plugins branch from 086f4ce to 5e9df69 Compare June 8, 2026 07:11
@gauriy-tech
gauriy-tech force-pushed the feature/XRAY-144809-include-mvn-plugins branch from 5e9df69 to 1eaaa16 Compare June 8, 2026 08:03
@gauriy-tech

Copy link
Copy Markdown
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@attiasas
attiasas requested a review from a team June 8, 2026 09:55

@attiasas attiasas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
Please add an integration test case with a project replicating that.
I would consider also adding this option to jf audit command. most of the logic is the same, users may want to include this in their scan as well

Comment thread cli/docs/flags.go Resolved
@attiasas

attiasas commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Also, why this is not implemented in maven-dep-tree? I may be a better solution
https://github.com/jfrog/maven-dep-tree

@gauriy-tech

Copy link
Copy Markdown
Collaborator Author

This is needed by a customer, we have consider it to take as a long term solution in https://github.com/jfrog/maven-dep-tree in upcoming quarter

@gauriy-tech

Copy link
Copy Markdown
Collaborator Author

Keeping it for curation scope for this PR , will connect with audit team to discuss enabling for their workflow

@gauriy-tech
gauriy-tech force-pushed the feature/XRAY-144809-include-mvn-plugins branch from 1eaaa16 to 11f8efd Compare June 9, 2026 07:10
@gauriy-tech

Copy link
Copy Markdown
Collaborator Author

Added an integration test case maven tree - one blocked plugin dependency in TestDoCurationAudit (commands/curation/curationaudit_test.go), with a new fixture under tests/testdata/projects/package-managers/maven/maven-curation-plugin-deps/.

What it tests (real mvn run against the mock curation server):

jf ca --mvn-include-plugin-deps detects a curation-blocked artifact that only enters the build via a Maven build plugin's transitive closure — the exact "0 blocked in jf ca but build is blocked" scenario.
Fixture pins maven-jar-plugin:3.4.1, whose fixed closure pulls org.ow2.asm:asm:9.8 (via plexus-archiver:4.9.2). asm is not in mvn dependency:tree, so without the flag it's invisible.
Verifies the end-to-end path: flag wiring → dependency:resolve-plugins → parse → inject into dep graph → curation HEAD probe → blocked PackageStatus (org.ow2.asm:asm:9.8, maven, {pol1, cond1}).

…include-mvn-plugins

# Conflicts:
#	commands/curation/curationaudit.go
#	sca/bom/buildinfo/technologies/common.go
@attiasas

attiasas commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

This is needed by a customer, we have consider it to take as a long term solution in https://github.com/jfrog/maven-dep-tree in upcoming quarter

Should be documented that this is a "temp" fix. I whould rather you add it to the actual maven-dep-tree repo and we will add this only if its urgent until actually implemented. should be documented and tracked

@gauriy-tech

Copy link
Copy Markdown
Collaborator Author

This is needed by a customer, we have consider it to take as a long term solution in https://github.com/jfrog/maven-dep-tree in upcoming quarter - https://jfrog-int.atlassian.net/browse/XRAY-145307

@gauriy-tech
gauriy-tech requested a review from attiasas June 9, 2026 07:40
@attiasas attiasas added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jun 9, 2026
@github-actions github-actions Bot removed the safe to test Approve running integration tests on a pull request label Jun 9, 2026
@attiasas attiasas changed the title XRAY-144809 - Fixed maven to consider plugin deps during jf ca XRAY-144809 - CA command [Maven]: Add option to consider plugin deps Jun 9, 2026

@attiasas attiasas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. pending to see logic moved to maven-dep-tree

@attiasas
attiasas merged commit be8d63a into jfrog:dev Jun 9, 2026
57 of 72 checks passed
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
jfrog-cli 2.108.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What changed in v2.108.0

> Auto-generated from 6 repositories · 2026-06-11  
> Comparing `v2.107.0` → `v2.108.0`

> ℹ️  No changes in: gofrog

### ✨ New Features

- **[build-info-go]** Added pnpm package support to recognise 403 Forbidden output [#389](jfrog/build-info-go#389) (@Phavya-jfrog)
- **[jfrog-cli]** Add jf mcp command to configure the remote JFrog MCP server [#3533](jfrog/jfrog-cli#3533) (@ehl-jf)
- **[jfrog-cli]** Add AI context description to commands [#3503](jfrog/jfrog-cli#3503) (@ehl-jf)
- **[jfrog-cli]** feat: add server id to login command [#3394](jfrog/jfrog-cli#3394) (@tim-goto)
- **[jfrog-cli]** RTECO-1021 - Enhance metrics visibility by including package manager context [#3534](jfrog/jfrog-cli#3534) (@fluxxBot)
- **[jfrog-cli]** Make nix command visible [#3539](jfrog/jfrog-cli#3539) (@reshmifrog)
- **[jfrog-cli]** Added Post Failure Run support for pnpm and Yarn [#3509](jfrog/jfrog-cli#3509) (@Phavya-jfrog)
- **[jfrog-cli-artifactory]** JGC-473 - Add AI-agent help text to artifactory commands [#455](jfrog/jfrog-cli-artifactory#455) (@ehl-jf)
- **[jfrog-cli-artifactory]** RTECO-1021 - Enhance metrics visibility by including package manager context [#481](jfrog/jfrog-cli-artifactory#481) (@fluxxBot)
- **[jfrog-cli-artifactory]** RTECO-1400 - Add path validation to prevent traversal attacks in artifact handling [#487](jfrog/jfrog-cli-artifactory#487) (@fluxxBot)
- **[jfrog-cli-core]** RTECO-1021 - Enhance metrics visibility by including package manager context [#1569](jfrog/jfrog-cli-core#1569) (@fluxxBot)
- **[jfrog-cli-security]** Support parsing SCA issues without components [#758](jfrog/jfrog-cli-security#758) (@attiasas)
- **[jfrog-cli-security]** JGC-473 - Add AI-agent help text to security commands [#760](jfrog/jfrog-cli-security#760) (@ehl-jf)
- **[jfrog-cli-security]** Feature/xray 138688 add yarn support for jf ca [#759](jfrog/jfrog-cli-security#759) (@gauriy-tech)
- **[jfrog-cli-security]** XRAY-144809 - CA command [Maven]: Add option to consider plugin deps [#771](jfrog/jfrog-cli-security#771) (@gauriy-tech)
- **[jfrog-cli-security]** Feature/xray 138688 add pnpm support for jf ca [#769](jfrog/jfrog-cli-security#769) (@gauriy-tech)

### 🐛 Bug Fixes

- **[build-info-go]** RTECO-1287 jf poetry install --only main captures all dependency  [#391](jfrog/build-info-go#391) (@reshmifrog)
- **[jfrog-cli]** RTECO 1296 fix repeated 401 errors before fallback authentication [#3537](jfrog/jfrog-cli#3537) (@reshmifrog)
- **[jfrog-cli]** RTECO-1287 jf poetry install --only main captures all dependency  [#3530](jfrog/jfrog-cli#3530) (@reshmifrog)
- **[jfrog-cli-artifactory]** Updated logic for extracting repository key in case of reverse proxy scenario [#458](jfrog/jfrog-cli-artifactory#458) (@naveenku-jfrog)
- **[jfrog-cli-core]** Revert "Fix reference token privilege escalation" [#1571](jfrog/jfrog-cli-core#1571) (@reshmifrog)
- **[jfrog-cli-security]** XRAY-140212 - Updated gradle dep tree jar with the missing deps fix [#751](jfrog/jfrog-cli-security#751) (@gauriy-tech)
- **[jfrog-cli-security]** fix: disable npm workspaces for native config reads [#762](jfrog/jfrog-cli-security#762) (@omribz156)

### 📦 Other Changes

- **[build-info-go]** RTECO-1365 Include e2e tests from jfrog cli to build-info-go [#390](jfrog/build-info-go#390) (@reshmifrog)
- **[jfrog-cli-artifactory]** pnpm update error output handling [#465](jfrog/jfrog-cli-artifactory#465) (@Phavya-jfrog)
- **[jfrog-cli-security]** Auto install Cocoapods when Podfile.lock not exist [#723](jfrog/jfrog-cli-security#723) (@attiasas)
- **[jfrog-client-go]** Use Windows system certificate store for CLI TLS transport [#1351](jfrog/jfrog-client-go#1351) (@RemiBou)

---

### 📊 Summary

| Repository | Changes |
|---|---|
| [jfrog-cli](https://github.com/jfrog/jfrog-cli) | 8 |
| [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | 8 |
| [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | 5 |
| [build-info-go](https://github.com/jfrog/build-info-go) | 3 |
| [jfrog-cli-core](https://github.com/jfrog/jfrog-cli-core) | 2 |
| [jfrog-client-go](https://github.com/jfrog/jfrog-client-go) | 1 |
| **Total** | **27** |

### 🔗 Module Version Changes

| Module | From | To |
|---|---|---|
| [build-info-go](https://github.com/jfrog/build-info-go) | `v1.13.1-0.20260528065004-80409c046540` | `v1.13.1-0.20260610071651-260ad6720e0d` |
| [jfrog-cli-artifactory](https://github.com/jfrog/jfrog-cli-artifactory) | `v0.8.1-0.20260603105750-3886c0f01286` | `v0.8.1-0.20260610074911-82ce7d90edbd` |
| [jfrog-cli-core](https://github.com/jfrog/jfrog-cli-core) | `v2.60.1-0.20260601130310-8d52a530da18` | `v2.60.1-0.20260609101026-df3091b39d06` |
| [jfrog-cli-security](https://github.com/jfrog/jfrog-cli-security) | `v1.29.3` | `v1.30.0` |
| [jfrog-client-go](https://github.com/jfrog/jfrog-client-go) | `v1.55.1-0.20260528115006-6ca9682a3255` | `v1.55.1-0.20260603130552-af1dd449b994` |
</pre>
  <p>View the full release notes at <a href="https://github.com/jfrog/jfrog-cli/releases/tag/v2.108.0">https://github.com/jfrog/jfrog-cli/releases/tag/v2.108.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!11303

This branch had an error being deployed

1 failed deployment
frogbot — bf9752c5 Deployed Jun 9, 2026 by attiasas via scan-pull-request #3800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants