Repository navigation
Crash on web socket server connect #140
Description
Using NodeJS v8.9.0 and node-http-mitm-proxy v0.6.0 I encountered the following error whilst connecting via the mitm proxy:
Nov 03 15:23:56 /node_modules/http-mitm-proxy/lib/proxy.js:583
Nov 03 15:23:56 if (ctx.clientToProxyWebSocket.upgradeReq.url == '' || /^\//.test(ctx.clientToProxyWebSocket.upgradeReq.url)) {
Nov 03 15:23:56 ^
Nov 03 15:23:56
Nov 03 15:23:56 TypeError: Cannot read property 'url' of undefined
Nov 03 15:23:56 at Proxy._onWebSocketServerConnect (/node_modules/http-mitm-proxy/lib/proxy.js:583:45)
Nov 03 15:23:56 at emitTwo (events.js:126:13)
Nov 03 15:23:56 at WebSocketServer.emit (events.js:214:7)
Nov 03 15:23:56 at handleUpgrade (/node_modules/ws/lib/WebSocketServer.js:88:16)
Nov 03 15:23:56 at WebSocketServer.completeUpgrade (/node_modules/ws/lib/WebSocketServer.js:270:5)
Nov 03 15:23:56 at WebSocketServer.handleUpgrade (/node_modules/ws/lib/WebSocketServer.js:197:10)
Nov 03 15:23:56 at Server.WebSocketServer._ultron.on (/node_modules/ws/lib/WebSocketServer.js:87:14)
Nov 03 15:23:56 at emitThree (events.js:136:13)
Nov 03 15:23:56 at Server.emit (events.js:217:7)
Nov 03 15:23:56 at onParserExecuteCommon (_http_server.js:495:14)
Unfortunately I don't have details of the request that caused this crash.
Activity
ks07 commentedon Nov 7, 2017
I am able to reliably reproduce this problem when using the mitm proxy in front of chromium 59.0.3071.115 on Windows 10 when browsing to the following URL:
https://travel.stackexchange.com/questions/104883/electronic-items-to-take-from-us-to-india
The network inspector gives the following request details:
ks07 commentedon Nov 7, 2017
This was caused by the update of the
wsdependency to 3.2.0. TheupgradeReqproperty was removed in websockets/ws#1099