Repository navigation
Return Aura Sensor V2 devices from get_devices - #910
Draft
Herbertmt978 wants to merge 1 commit into
Draft
Herbertmt978 wants to merge 1 commit into
Herbertmt978 wants to merge 1 commit into
Conversation
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Author
|
Still relevant |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
get_devices()currently drops every device namedAura Sensor V2. Issue #587 includes a response for a real Sleep Analyzer with this name, typeSleep Monitorand model ID 63, so the filter hides a device that the API returned.Remove the exclusion introduced in #438 and pass these devices through the existing parser. This restores discovery while retaining the API's model name and device identifiers. It does not rename the analyser or change sleep measurements.
The regression tests cover an ID 63 monitor alone and alongside a scale. The existing fixture also checks that the previously excluded ID 13 record is returned.
All 62 tests pass on Python 3.13 and 3.14 with 100% coverage. The configured hooks and MyPy pass. Synthetic checks through Home Assistant's installed Withings coordinator and entity code also pass for the analyser alone and alongside model 5 and model 13 scales.
Related Issues