Skip to content
This repository was archived by the owner on Sep 7, 2026. It is now read-only.

fix underscore method for single letter words - #131

Merged
az7arul merged 1 commit into
jprichardson:masterfrom
az7arul:issue-86
Mar 16, 2015
Merged

az7arul merged 1 commit into
jprichardson:masterfrom
az7arul:issue-86

Conversation

@az7arul

@az7arul az7arul commented Mar 16, 2015

Copy link
Copy Markdown
Collaborator

This deals with #86

@jprichardson

Copy link
Copy Markdown
Owner

Looks good to me.

@az7arul

az7arul commented Mar 16, 2015

Copy link
Copy Markdown
Collaborator Author

@jprichardson whats the build process ? should I just merge this ?

@jprichardson

Copy link
Copy Markdown
Owner

Change process:

  1. Submit PR for significant changes (wait for acknowledgement), minor changes like bugfixes it's ok to commit directly yourself.
  2. Adhere to semver. Best explanation I've found of semver http://semver-ftw.org/
  3. You can use tin to alter versions for all package files https://github.com/jprichardson/tin.
  4. Make sure to update CHANGELOG.md.
  5. Run make min. (We should move to gulp)
  6. Commit the new version number with commit message being the version number. Should contain only the version number changes in package files, changelog changes, and new min file.
  7. Create a tag with with the version number. Tag message should be the changelog changes.
  8. Push and npm publish. Btw, what is your npm username?

@az7arul

az7arul commented Mar 16, 2015

Copy link
Copy Markdown
Collaborator Author

az7arul

@jprichardson

Copy link
Copy Markdown
Owner

Done.

@az7arul
az7arul merged commit c228b6b into jprichardson:master Mar 16, 2015
@az7arul

az7arul commented Mar 16, 2015

Copy link
Copy Markdown
Collaborator Author

Published to npm :)

@jprichardson

Copy link
Copy Markdown
Owner

👍 Awesome, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants