Repository navigation
Scan a cvs, Cvs or _DARCS folder, which CVS and darcs never write [patch] - #213
Merged
Merged
Conversation
…tch] CVS only ever names its metadata folder CVS and darcs only _darcs, so match those two names case-sensitively. A user's own cvs folder of receipts, or a Cvs or _DARCS folder, was silently left out of the scan. The dot-prefixed names (.git, .svn, .hg, .bzr) still ignore case. Fixes #211 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5UxX43LaxrXmD5Bhq
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211
What changed
FileScannerskipped any directory namedCVSor_darcsignoring case, so a user's owncvsfolder (receipts, say), or aCvsor_DARCSfolder, was silently left out of the scan. CVS only ever writesCVSand darcs only_darcs, so those two names now match case-sensitively, in their own set. The dot-prefixed names (.git,.svn,.hg,.bzr) still ignore case, as before.Tests
TheScanReadsAUserFolderNamedLikeCvsOrDarcsInAnotherCase(cvs,Cvs,cVS,_DARCS,_Darcs): the scan finds all three files.ScanReportsTheCopiesInALowercaseCvsFolder: the issue's repro, whereScanreportsFound 3 file(s).and all three copies.TheScanSkipsVersionControlMetadataDirectoriesrows forCVSand_darcsstill pass.All 6 new cases fail with the fix reverted. The full suite passes: 151 passed, 3 skipped.
Generated by Claude Code