Skip to content

fix: normalize quantity overflow errors - #2737

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-client:masterfrom
KeuqS:fix/parse-quantity-overflow-2735
Oct 13, 2026
Merged

kubernetes-prow[bot] merged 2 commits into
kubernetes-client:masterfrom
KeuqS:fix/parse-quantity-overflow-2735

Conversation

@KeuqS

@KeuqS KeuqS commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

/kind bug

What this PR does / why we need it:

Normalize decimal overflow errors raised by parse_quantity into ValueError so callers get a consistent exception type for malformed or unrepresentable quantities.

The implementation catches DecimalException only around the scaled multiplication. Existing valid quantities and other validation behavior remain unchanged.

Which issue(s) this PR fixes:

Fixes #2735

Special notes for your reviewer:

Added a regression test for the overflowing quantity 2.e388635141Ki. No Kubernetes cluster is required to reproduce or test this behavior.

Does this PR introduce a user-facing change?

No. This makes the exception type consistent for invalid input.

NONE

@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Oct 12, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 12, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @KeuqS!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from roycaihw and yliaog October 12, 2026 22:04
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 12, 2026
@yliaog

yliaog commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KeuqS, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 0c34031 into kubernetes-client:master Oct 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parse_quantity raises decimal.Overflow instead of ValueError for some large quantities

2 participants