Fix websocket proxy auth with colon in password

[tilakraj-hub]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes websocket proxy authentication when the proxy password contains a colon (:).

Previously, proxy credentials were parsed using split(':'), which caused passwords containing colons to be truncated. This change uses split(':', 1) so the credentials are split only at the username/password separator and the complete password is preserved.

Which issue(s) this PR fixes:

Fixes #2734

Special notes for your reviewer:

The change is limited to the proxy authentication credential parsing in websocket_proxycare().

The reported issue was reproduced before the fix and verified after the change with a password containing multiple colons.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs, usage docs, etc.:

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tilakraj-hub / name: Tilak Raj Lunia (f857da4)

[kubernetes-prow]

Welcome @tilakraj-hub!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tilakraj-hub
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[roycaihw]

Thanks for the PR @tilakraj-hub! Issue #2734 is already being addressed by earlier PR #2738, which also adds unit test coverage in ws_client_test.py and guards against IndexError when credentials lack a colon. Closing as duplicate in favor of #2738.

[tilakraj-hub]

@roycaihw Thank you for reviewing my PR and for the clarification. I understand that this issue is already being addressed by PR #2738.
I’m still very interested in contributing to the Kubernetes Python ecosystem. If there are any other Python-related issues or repositories where you think I could make a useful contribution, I’d really appreciate it if you could point me in the right direction.
I’d be happy to work on another issue and contribute where needed. Thank you for your time and guidance!

[roycaihw]

Thanks for your interest in contributing @tilakraj-hub! Glad to see your CNCF CLA is now sorted out.

If you're looking for issues to tackle, a few good places to start:

• Check out open issues with the help wanted label: https://github.com/kubernetes-client/python/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22
• For something close to what you were just working on, take a look at Broken websocket client on custom authorization header names #2510 ("Broken websocket client on custom authorization header names" in ws_client.py).

Feel free to join the #kubernetes-client channel on Kubernetes Slack (https://slack.k8s.io/) if you'd like to chat or ask questions!