Repository navigation
fix(media): allow setting IO media via decorator update - #1005
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
Improved media object handling in the Python SDK's decorator system by consolidating JSON serialization of outputs for more reliable media object processing.
- Modified
_handle_call_resultin/langfuse/decorators/langfuse_decorator.pyto use single-step JSON serialization for outputs - Added media object support tests in
/tests/test_decorators.pyto verify nested media handling within input/output/metadata dictionaries - Enhanced decorator update functionality to properly handle LangfuseMedia objects in trace updates
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
hassiebp
enabled auto-merge (squash)
November 20, 2024 12:48
niklassemmler
added a commit
that referenced
this pull request
Oct 8, 2026
The bare `langfuse.observation.metadata` attribute (non-dict metadata) is now sent as `json.dumps(metadata, cls=EventSerializer)`, strings included, matching the per-key values and langfuse-js #1005. Previously strings were passed through raw, so `metadata="foo"` sent `foo` in Python but `"foo"` in JS. None is still not written. Input/output and other `_serialize` callers are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes JSON serialization of output in
_handle_call_resultinlangfuse_decorator.pyand updatestest_mediaintest_decorators.pyto verify media handling.langfuse_decorator.py,_handle_call_resultnow directly serializesresultusingjson.dumpsandjson.loadswithEventSerializerto ensure proper JSON serialization.test_decorators.py,test_mediais updated to check that media references ininput,output, andmetadataare correctly serialized and deserialized.This description was created by
for 1ad58c0. It will automatically update as commits are pushed.