Repository navigation
fix(prompts): use each non-dict placeholder item as message content in compile - #1972
Open
moneebullah25 wants to merge 2 commits into
Open
moneebullah25 wants to merge 2 commits into
moneebullah25 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a chat prompt placeholder is filled with a list containing non-dict items (for example
["a", "b"]),ChatPromptClient.compileappended one message per item but set every message's content tostr(placeholder_value), the stringified whole list. It now usesstr(msg), the current item, so each item becomes its own message.Fixes #1971
Type of change
Verification
List the main commands you ran:
Results: 41 passed. 18 errors in
tests/unit/test_prompt.py, allAttributeError: Langfuse client is not initializedraised from fixture setup; they are in tests this change does not touch (the changed parametrized case and the new test pass). The same 18 errors occur onmain(40 passed, 18 errors there, without the new test), so they are pre-existing. ruff check, ruff format anduv run --frozen mypy langfuseare clean. The e2e tests were not run.Checklist
code_review.md..env.templateif needed.
Confidence Score: 5/5
This PR appears safe to merge.Summary
Fixes
ChatPromptClient.compileso each non-dictionary placeholder item becomes its own message content, rather than repeating the whole list.Reviews (1) · Last reviewed commit: "fix(prompts): use each non-dict placehol..." · Reviewed by Greptile