Repository navigation
Percent margins - #126
Merged
Merged
Percent margins#126
Conversation
Member
|
Thanks @vandyshev for your PR 🎉, I'll check your PR, but don't worry about the failure of travis, I have fixed it in my latest PR |
lucdion
reviewed
Mar 21, 2018
|
|
||
| @discardableResult | ||
| func marginEnd(_ percent: Percent) -> PinLayout { | ||
| return isLTR() ? marginRight(percent) : marginLeft(percent) |
Member
There was a problem hiding this comment.
Here if there is a warning, the message will display the wrong context (either marginRight or marginLeft), it should display "marginEnd".
lucdion
reviewed
Mar 21, 2018
|
|
||
| @discardableResult | ||
| func marginHorizontal(_ percent: Percent) -> PinLayout { | ||
| return marginLeft(percent).marginRight(percent) |
lucdion
reviewed
Mar 21, 2018
|
|
||
| @discardableResult | ||
| func marginVertical(_ percent: Percent) -> PinLayout { | ||
| return marginTop(percent).marginBottom(percent) |
lucdion
reviewed
Mar 21, 2018
| } | ||
| } | ||
|
|
||
| describe("the result of left&right percent margins when only the width is specified") { |
Member
There was a problem hiding this comment.
Excellent unit tests, could you just add fews in the WarningSpec.
lucdion
requested changes
Mar 21, 2018
lucdion
left a comment
Member
There was a problem hiding this comment.
Excellent work!
Just some small changes required
Contributor
Author
|
@lucdion Ok, will be fixed |
lucdion
approved these changes
Mar 22, 2018
lucdion
left a comment
Member
There was a problem hiding this comment.
Good work, thanks for contributing! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add percent support for margins