Repository navigation
Conversation
Contributor
|
It would be nice to remove |
Contributor
|
Or we can also leave it as is but I feel that there is a bit of repetition there since no view should override |
Member
Author
|
@antoinelamy I will keep it that way in this PR, but we have a discussion about this. |
|
@lucdion @antoinelamy my 2cents would be to remove from the SizeCalculable protocol for UIKit consistency. Thanks for the great work on PinLayout and FlexLayout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a method
sizeToFit().The method adjust the view's size based on the result of the method
UIView.sizeToFit()Example: