Repository navigation
Update relative methods signatures when specifying multiple relative views - #48
Merged
Merged
Conversation
…views. Instead of having a variadic parameter, method `above(of…)`, `below(of…)`, `left(of…)` and `right(of…)` now takes either a single UIView or an Array of UIViews. This make it easier to call these methods if the developper has already an array of UIViews. Variadic parameters are quite limited in Swift, they don’t accept an Array, which other language accept. Plus: * Refactor source code to split PinLayout’s implementation in multiple files.
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=========================================
- Coverage 95.93% 95.5% -0.43%
=========================================
Files 15 19 +4
Lines 3245 3273 +28
=========================================
+ Hits 3113 3126 +13
- Misses 132 147 +15
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having a variadic parameter, method
above(of…),below(of…),left(of…)andright(of…)now takes either a single UIView or an Array of UIViews.This make it easier to call these methods if the developper has already an array of UIViews. Variadic parameters are quite limited in Swift, they don’t accept an Array, which other language accept.
Plus: