Skip to content

Add method that can pin multiples edges - #93

Merged
lucdion merged 3 commits into
masterfrom
add_pin_all
Oct 30, 2017
Merged

lucdion merged 3 commits into
masterfrom
add_pin_all

Conversation

@lucdion

@lucdion lucdion commented Oct 30, 2017

Copy link
Copy Markdown
Member

Add method that can pin multiples edges:

  • all(): Pin all edges on its superview's corresponding edges (top, bottom, left, right). Similar to calling view.top().bottom().left().right()
  • horizontally(): Pin the left and right edges on its superview's corresponding edges. Similar to calling view.left().right().
  • vertically(): Pin the top and bottom edges on its superview's corresponding edges. Similar to calling view.top().bottom().

Luc Dion added 3 commits October 27, 2017 14:32
* `all()`: Pin all edges on its superview's corresponding edges (top, bottom, left, right). Similar to calling `view.top().bottom().left().right()`
* `horizontally()`: Pin the left and right edges on its superview's corresponding edges. Similar to calling `view.left().right()`.
* `vertically()`: Pin the **top and bottom edges** on its superview's corresponding edges. Similar to calling `view.top().bottom()`.
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #93 into master will increase coverage by 0.07%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   89.44%   89.51%   +0.07%     
==========================================
  Files          31       31              
  Lines        5692     5810     +118     
==========================================
+ Hits         5091     5201     +110     
- Misses        601      609       +8
Impacted Files Coverage Δ
Sources/PinLayout.swift 100% <ø> (ø) ⬆️
Sources/ObjectiveC/PinLayoutObjC.swift 0% <ø> (ø) ⬆️
Sources/ObjectiveC/PinLayoutObjCImpl.swift 0% <0%> (ø) ⬆️
Tests/BasicView.swift 80% <0%> (-0.65%) ⬇️
Tests/PinEdgesSpec.swift 100% <100%> (ø) ⬆️
Sources/PinLayoutImpl.swift 84.16% <83.33%> (+0.17%) ⬆️
Sources/PinLayoutImpl+Coordinates.swift 87.65% <93.75%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f92ab4...a1f2869. Read the comment docs.

@lucdion
lucdion merged commit 1109be7 into master Oct 30, 2017
@lucdion
lucdion deleted the add_pin_all branch October 30, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants