refactor(MultiTape): use RelSeries and shared space accounting - #946
Merged
SamuelSchlesinger merged 1 commit intoSep 24, 2026
Merged
Conversation
barni120400
requested review from
SamuelSchlesinger,
arademaker,
chenson2018,
fmontesi,
kim-em and
sorrachai
as code owners
September 23, 2026 22:40
Collaborator
|
This looks quite nice to me. Needs a rebase. |
crei
reviewed
Sep 24, 2026
| namespace RunPath | ||
|
|
||
| /-- The number of steps taken by a run path. -/ | ||
| def time (p : ntm.RunPath input) : ℕ := p.length |
Collaborator
There was a problem hiding this comment.
Thus could be annoying but I’m wondering if we should not have “p.length - 1”. The time should be the number of transitions. If the RelSeries counts the number of elements then a RunPath with just one element should take zero time.
Contributor
Author
There was a problem hiding this comment.
RelSeries.length already counts transitions so this is ok.
barni120400
force-pushed
the
refactor/multitape-run-path
branch
from
September 24, 2026 15:22
9356bda to
cce9355
Compare
Contributor
Author
|
@SamuelSchlesinger rebased |
SamuelSchlesinger
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace list-based computation paths with Mathlib's
RelSeries. Count space per tape directly on the path, so a deterministic run and its corresponding path use the same space by definition.