refactor(Circuit): describe output tuples with Computes - #948
Open
SamuelSchlesinger wants to merge 2 commits into
Open
SamuelSchlesinger wants to merge 2 commits into
SamuelSchlesinger wants to merge 2 commits into
Conversation
SamuelSchlesinger
requested review from
arademaker,
chenson2018,
fmontesi,
kim-em and
sorrachai
as code owners
September 24, 2026 00:47
This was referenced Sep 24, 2026
crei
reviewed
Sep 24, 2026
SamuelSchlesinger
changed the base branch from
samschles/circuit-shared-boolean
to
main
September 24, 2026 12:38
SamuelSchlesinger
force-pushed
the
samschles/circuit-outputs
branch
from
September 24, 2026 12:48
c7bf320 to
7fa6dfa
Compare
barni120400
pushed a commit
to barni120400/cslib
that referenced
this pull request
Sep 24, 2026
…r#947) ## Summary - Define `Cslib.BitString` and `Cslib.BooleanFunction` in Foundations. - Update Boolean circuits to import and use the shared definitions, so other Boolean complexity developments can use these types without a circuit dependency. This is the first part of the split of leanprover#943. The stack continues in leanprover#948 and leanprover#949. ## Validation - `lake build --wfail --iofail` - `lake exe mk_all --check` - `lake test` - `lake lint` - `lake exe lint-style` Codex assisted with splitting leanprover#943 into three focused PRs and running these local checks.
crei
approved these changes
Sep 24, 2026
Collaborator
Author
|
@fmontesi friendly ping to merge |
SamuelSchlesinger
added this pull request to stack #953
September 25, 2026 03:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Circuit.Computesto specify all designated outputs as a function returning an output tuple.Circuit.wiringfor selecting, permuting, and duplicating inputs, with size, depth, evaluation, and computation lemmas.Synthesis.exists_circuit_outputsand adapt scalar counting, Shannon, Lupanov, and tests to the tuple-valued API.This is the second part of the split of #943. It builds on #947 and retains the explicit gate-count index; #949 changes that representation.
Validation
lake build --wfail --iofaillake exe mk_all --checklake testlake lintlake exe lint-styleCodex assisted with splitting #943 into three focused PRs, adapting this output change to the explicit gate-count representation, and running these local checks.