feat(Circuit): sequential and parallel composition of circuits - #951
Closed
SamuelSchlesinger wants to merge 3 commits into
Closed
SamuelSchlesinger wants to merge 3 commits into
SamuelSchlesinger wants to merge 3 commits into
Conversation
SamuelSchlesinger
requested review from
arademaker,
chenson2018,
fmontesi,
kim-em and
sorrachai
as code owners
September 25, 2026 02:57
Collaborator
Author
|
Reopened from an in-repo branch so it can be stacked on #949. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Program.appendcontinues a program by a second one whose inputs are read from wires of the first. Feeding it the outputs givesCircuit.comp, feeding it the inputs givesCircuit.appendon shared inputs. Both evaluate as expected and add gate counts.Also adds
Circuit.ComputesOn, computing a function on a support, asSet.EqOn, with composition and pairing lemmas for it and forComputes;Wire.castAddfor embedding wires into a continued program; and twoFin.appendsimp lemmas.Based on #949.