Skip to content

Unstable - Incorrect snack bar notification when bulk editing resources #4654

Closed

Description

@pcenov

Observed behavior

When I am bulk editing resources if I select the Apply to all resources and folders nested within the selected folders and I click 'Save' then I see an incorrect snack bar message that I've just edited 1 resource.

Expected behavior

Correct number of edited resources, or stating that multiple resources have been edited.

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel with folders and all of the supported resources
  3. Select a folder with multiple resources and bulk edit all of the resources within the folder
  4. Observe the snack bar message

Additional information

message.2.mp4

Console logs

no errors observed in the console

Usage Details

Activity

  1. pcenov commented on Aug 16, 2024

    @pcenov
    MemberAuthor
  2. marcellamaki commented on Aug 21, 2024

    @marcellamaki
    Member

    I think here we can just remove the reference to resources entirely and have the snackbar say "Edited 'levels'" or "Edited 'categories'" ?

    I'm not sure the level of granular detail with the number of resources is really required, since the action has already been completed. How does that sound? @radinamatic (and @pcenov if you have any ideas!)

  3. radinamatic commented on Aug 21, 2024

    @radinamatic
    Member

    Yes, we were considering an more generic wording, and actually we already have the Changes saved string (we have it in 3 places, for that matter 😂, some cleanup needed) on Crowdin.

  4. radinamatic commented on Aug 27, 2024

    @radinamatic
    Member

    Manual QA on the unstable branch confirms the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions