Repository navigation
Add helper text for the "?" in the license/source modal #4679
Description
Noticed in the Aug 20 bug bash
Current behavior
The "?" seems like it should be a clickable button, and in the full screen edit modal, it is interactive.
Not sure if this was not specced, or if it just is still to be implemented, but I think this is meant to be interactive.
Activity
radinamatic commentedon Aug 28, 2024
In the full Edit details window this
?button opens the About licenses modal, but I would recommend against opening one modal on top of the other.LianaHarris360 commentedon Aug 29, 2024
@radinamatic Is there an alternative, preferred way for displaying that information? Should the "About licenses" be presented as a full page?
radinamatic commentedon Aug 29, 2024
Been thinking about that since yesterday... 🤔
Full page is certainly a preferred option, but I'm not sure if/how that refactor and regression testing plays with our current release plans. cc @marcellamaki and @jtamiace for thoughts.
marcellamaki commentedon Aug 29, 2024
i really don't know if this is a good idea, but what if (for the short term) we got rid of the ? and added, below, an "About licenses ⌄" small link style button, show this all inline in the modal, and then a "show less" at the bottom to close it. Not great. but perhaps better than a modal in modal, and probably much more reasonable than a more significant refactor right now.
marcellamaki commentedon Aug 30, 2024
Removing the user string labels for string freeze/translation tracking purposes, as the strings are already present in a shared translation file.
LianaHarris360 commentedon Sep 5, 2024
Would it be beneficial to implement a toggle link style button with a downward and upward arrow to control the display of the About Licenses section? For example:
radinamatic commentedon Sep 9, 2024
Yes, this looks great, @LianaHarris360, thank you! 💯 👏🏽