Extraneous strings on the Edit details page when editing HTML5 apps

@marcellamaki

Observed behavior

For the HTML5 apps there's an extraneous (or I'm forgetting what it was supposed to be) link with ConstantStrings.imscp_zip string 🤔

Errors and logs

…

Expected behavior

There should be no extraneous strings.

User-facing consequences

Incomplete resource file information

Steps to reproduce

…

Usage Details

OS: Windows
Browser: Firefox & Chrome
tested with Kolibri QA channel (nakav-mafak) and other manually curated channels

@marcellamaki suggested that it might be related to #4205

@radinamatic

@radinamatic It looks like the ConstantStrings.imscp_zip doesn't exist in

studio/contentcuration/contentcuration/frontend/shared/mixins.js

Line 89 in 69be8e5

export const constantStrings = createTranslator('ConstantStrings', {

.

For the HTML5 apps there's also an extraneous (or I'm forgetting what it was supposed to be) link with ConstantStrings.imscp_zip string

It would be good to establish what its intended purpose was before we remove it although I suspect this is just another file that was uploaded. In that case adding the String would suffice. Anyone recall anything? cc @rtibbles @bjester

@radinamatic

Also @radinamatic, I am not able to replicate the "Unknown filename" link issue. I seem to consistently get the file name

@pcenov

Both @pcenov and I are currently replicating the "Unknown filename" link in Kolibri QA channel in ASB books and Flexbooks at least (Firefox and Chrome)

Thanks replicated.

It turns out that the these particular resources have "file" as their name. Any resource with "file" is defaulted to Unknown filename, which is a little misleading, maybe setting the string to something else would make more sense to the user. Happy to hear thoughts here.

studio/contentcuration/contentcuration/frontend/channelEdit/views/files/FileUploadItem.vue

Lines 137 to 143 in b9f89e9

    
                 formattedFileDisplay() { 
        
                   const fileName = this.fileDisplay.original_filename; 
        
                   if (fileName === 'file' || !fileName) { 
        
                     return this.$tr('unknownFile'); 
        
                   } 
        
                   return fileName; 
        
                 },

I don't think Unknown filename is a bug, in regards to what was fixed previously #3602 because the prior reported issue was that this was untranslated. We simply don't have any more information to provide to the user.

I think addressing the extraneous option for HTML5 apps is higher priority.

I have update and split the issue so they can be handled separately.

Because we already have a file in the IMSCP format in the database, removal isn't the best option since this would break the UI for the user. As such, this issue will be fixed by adding a new strings and shipped in a later release, as we would need to do translations.

Verified as fixed #4818

Navigation Menu

Repository navigation

Extraneous strings on the Edit details page when editing HTML5 apps #4789

Observed behavior

Errors and logs

Expected behavior

User-facing consequences

Steps to reproduce

Usage Details

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	formattedFileDisplay() {
	const fileName = this.fileDisplay.original_filename;
	if (fileName === 'file' \|\| !fileName) {
	return this.$tr('unknownFile');
	}
	return fileName;
	},

Extraneous strings on the Edit details page when editing HTML5 apps #4789

Description

Observed behavior

Errors and logs

Expected behavior

User-facing consequences

Steps to reproduce

Usage Details

Activity

akolson commented on Nov 12, 2024

akolson commented on Nov 12, 2024

radinamatic commented on Nov 12, 2024

akolson commented on Nov 12, 2024

akolson commented on Nov 12, 2024

bjester commented on Nov 12, 2024

akolson commented on Nov 12, 2024

akolson commented on Nov 12, 2024

bjester commented on Nov 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions