Skip to content

ci: update reusable workflow paths to kebab-case - #138

Merged
dclong merged 2 commits into
mainfrom
push-nlvxymxlpvrv
Aug 16, 2026
Merged

dclong merged 2 commits into
mainfrom
push-nlvxymxlpvrv

Conversation

@dclong

@dclong dclong commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • ci: update reusable workflow paths to kebab-case
  • ci: rename workflows to kebab-case

Changed files

Modified

  • .github/workflows/claude.yaml (+1/-1)
  • .github/workflows/pr-workflow.yaml (+1/-1)
  • github_rest_api/scripts/github/create_github_repo.py (+1/-1)
  • tests/test_create_github_repo.py (+2/-2)
    Renamed
  • .github/workflows/check-workflow-template.yaml (+0/-0)
  • .github/workflows/create-pr-dev-to-main.yaml (+1/-1)
  • .github/workflows/create-pr-to-dev.yaml (+1/-1)
  • .github/workflows/create-pr-to-main.yaml (+1/-1)
  • .github/workflows/merge-pr.yaml (+4/-4)
  • .github/workflows/remove-branch.yaml (+1/-1)

Commits

  • c60ac75 ci: update reusable workflow paths to kebab-case
  • 1f6cd1f ci: rename workflows to kebab-case

@dclong

dclong commented Aug 16, 2026 •

Copy link
Copy Markdown
Collaborator Author

Claude finished @dclong's task in 1m 37s —— View job


Claude finished the review

Todo list

  • Gather context (PR diff, changed files, CLAUDE.md)
  • Understand the request (run /code-review:code-review on this PR)
  • Run code review
  • Post review feedback and auto-merge decision

Review

This PR renames .github/workflows/* files from snake_case to kebab-case and updates all in-repo references accordingly.

What I checked

  • git diff origin/main...HEAD — full diff of all 10 changed files.
  • Searched the repo for any leftover references to the old snake_case workflow filenames (check_workflow_template, create_pr_dev_to_main, create_pr_to_dev, create_pr_to_main, auto_merge_pull_request.yaml, remove_branch.yaml) — none found. The remaining snake_case hits are Python module/function names and YAML job IDs, which are unrelated and correctly left as-is.
  • github_rest_api/scripts/github/create_github_repo.py:22 — _REPO_ONLY_WORKFLOWS constant updated to "check-workflow-template.yaml", consistent with the renamed file, and its only usage (line 225) is unaffected.
  • tests/test_create_github_repo.py — fixture strings updated to match the new filename; the test still exercises the same logic.

Note (non-blocking): Several uses: paths now point at renamed/re-extensioned files in the external legendu-net/.github repo, e.g. .github/workflows/claude.yaml now references .../claude.yaml@main (previously .../claude.yml@main), pr-workflow.yaml references .../claude-code-review.yaml@main (previously .../claude-code-review.yml@main), and merge-pr.yaml references .../merge-pr.yaml@main (previously .../auto_merge_pull_request.yaml@main — a semantic rename, not just kebab-casing). I don't have network access in this sandbox to confirm those paths exist in legendu-net/.github, so I can't independently verify them, but this matches the PR's stated intent of syncing with that repo's renamed reusable workflows. Worth a quick manual confirmation that the target repo's files were renamed to match before merging, since a mismatch would only surface at workflow-run time.

I was unable to run uv run pytest / ruff in this sandbox (command execution requires approval that isn't available here); the changes are small and mechanical (string renames), and I traced them by hand — I didn't find any inconsistency.

No correctness bugs found in the code changes themselves.

AUTO_MERGE_APPROVED

@dclong
dclong merged commit d2ef7f2 into main Aug 16, 2026
21 of 22 checks passed
@dclong
dclong deleted the push-nlvxymxlpvrv branch August 18, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant