fix(win32): start clusters via pg_ctl so elevated shells can run - #39
Open
Nabaatxaneh wants to merge 1 commit into
Open
Nabaatxaneh wants to merge 1 commit into
Nabaatxaneh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, postgres.exe refuses to start whenever the calling token is in the Administrators group (`Execution of PostgreSQL by a user with administrative permissions is not permitted''). Spawning postgres.exe directly therefore makes every elevated shell unable to start a cluster at all -- initialise() succeeds (initdb de-elevates internally) and only start() fails, which is confusing to diagnose.
pg_ctl is the binary Postgres ships for exactly this case: it builds a restricted token (get_restricted_token) and starts the postmaster under it. It is already exported by every platform package (including @embedded-postgres/windows-x64) -- it just was not used.
This change routes start()/stop() through pg_ctl on win32 only:
Scoped to win32 so macOS/Linux CI keeps exercising the direct-spawn path. Proven in production: this is a source-level port of a patch carrying the same logic against 18.1.0-beta.16, under which embedded-Postgres integration suites execute in elevated Windows sessions for the first time (previously 0 ran), with no leaked postmasters.