This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Repository navigation
Support tolerations - #1211
Open
thomasschoeftner wants to merge 16 commits into
Open
Support tolerations#1211thomasschoeftner wants to merge 16 commits into
thomasschoeftner wants to merge 16 commits into
Conversation
This was referenced Jul 2, 2022
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the capability to define tolerations to cloudflow pods.
Why are the changes needed?
This change adds the bare minimum functionality to allow isolating workloads on specific K8S nodes/node pools.
Ideally, this would be combined with affinities, but these are much more elaborate to configure.
When putting different taints on every K8S node pool, tolerations alone are sufficient to assign Pods to a specific node pool.
This change was also recently requested in #1207
Does this PR introduce any user-facing change?
More config options are available (documented in
adocfile)How was this patch tested?
Extra unit tests were added for
CloudflowConfigAkkaRunner