Skip to content

Support DNS hostnames in gossip #1313

Closed

Description

Activity

  1. ritikramuka commented on Feb 19, 2022

    @ritikramuka

    Greetings everyone, 👋
    I'd be happy to work on this issue.
    I'm new to this project and I just started learning rust to contribute here. I hope this will be a good starting point for contributing.

    Can I take this up? I'll also be glad to be guided a bit.

  2. TheBlueMatt commented on Feb 21, 2022

    @TheBlueMatt
    CollaboratorAuthor

    Sure, this is basically as simple as adding a new variant to the NetAddress type.

  3. ritikramuka commented on Feb 22, 2022

    @ritikramuka

    I am completely new to this so could you provide some more details. I am unable to figure out where to add this new variant to the NetAddress type.

  4. TheBlueMatt commented on Feb 22, 2022

    @TheBlueMatt
    CollaboratorAuthor

    Just take a look at how the existing variants work (eg OnionV3, etc) and add a parallel one for DNSHostname :). More guidance than that and I'd just write the code.

  5. a-mpch commented on Feb 23, 2022

    @a-mpch
    Contributor

    Hey @ritikramuka 👋🏼
    I started checking out this issue but I didn't write anything. I just pushed some code maybe we could see it together as is my first issue too. What do you think? :)

  6. linked a pull request that will close this issueAdds DNS hostname to NetAddress #1553on Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions