Repository navigation
docs: fix stale dashboard, Grafana and books links - #2159
Open
SatvikMishra08 wants to merge 1 commit into
Open
SatvikMishra08 wants to merge 1 commit into
SatvikMishra08 wants to merge 1 commit into
Conversation
The viz dashboard and Grafana are no longer described on the architecture page, so point these links at features/dashboard (#linkerd-dashboard and #grafana) instead. The books demo no longer has a service-profiles section, so link to the demo page itself. Applied to 2-edge and 2.19. Signed-off-by: Satvik Mishra <Satvikmishra.ipu146183@maims.ac.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #2158, covering the three stale links I left out of that one because they needed a new target and not just a corrected id. Applied to both
2-edgeand2.19:reference/cli/viz.md: "Check out the architecture docs" linked toreference/architecture/#dashboard, but the architecture page no longer covers the viz dashboard. The dashboard is described atfeatures/dashboard/#linkerd-dashboard, so the link (and its text) now point there.tasks/exposing-dashboard.md: the DNS-rebinding note linked toreference/architecture/#grafana, which doesn't exist either. Changed it tofeatures/dashboard/#grafana.tasks/setting-up-service-profiles.md:books/#service-profilespointed at a section that's gone (the books demo now walks through HTTPRoute, retries and timeouts), so it now links to the demo page itself.I checked each new target against the heading ids on the live linkerd.io pages.