Repository navigation
lib: bound parse_canframe input length - #633
Closed
seldatrgt35 wants to merge 1 commit into
Closed
seldatrgt35 wants to merge 1 commit into
seldatrgt35 wants to merge 1 commit into
Conversation
Pass the available input buffer size to parse_canframe() and reject buffers without a null terminator inside that bound. This prevents the parser from reading beyond unterminated input buffers. Fixes: linux-can#632 Signed-off-by: Selda Nur Turgut <seldanur.turgut@ogr.deu.edu.tr>
Member
|
Nothing to fix here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass the available input buffer size to
parse_canframe()and rejectinput that has no null terminator within that bound.
Update all four callers to provide the available buffer size. This
prevents the unbounded
strlen()read reported in #632 while preservingthe existing parsing behavior for valid CAN CC, CAN FD, CAN XL, and RTR
frame strings.
Validation
cansend,canplayer,log2asc, andlog2longgit diff --checkpassedCMake configuration was not completed in the local WSL environment
because
pkg-configis unavailable; the Make builds passed.Fixes #632