Repository navigation
fix(thunderphone): use _shorten_id after the openai_utils rename - #8229
Merged
Merged
Conversation
#7958 renamed _shorten_call_id to _shorten_id in openai_utils but did not update the thunderphone plugin or its tests. The import fails, so type-check and unit-tests fail on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tinalenguyen
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7958 renamed
_shorten_call_idto_shorten_idinopenai_utils, but the thunderphone plugin and its tests still import the old name. The import fails, sotype-checkandunit-testsfail on main and on every PR that merges with it.The behavior is unchanged:
_shorten_idkeeps the same 32-char cap and SHA-256 fallback, so thunderphone's call-id mapping still matches.Initial prompt and agent context
Model: Claude Opus 5.5