Skip to content

fix(thunderphone): use _shorten_id after the openai_utils rename - #8229

Merged
chenghao-mou merged 1 commit into
mainfrom
chenghao/fix/thunderphone-shorten-id
Oct 29, 2026
Merged

chenghao-mou merged 1 commit into
mainfrom
chenghao/fix/thunderphone-shorten-id

Conversation

@chenghao-mou

Copy link
Copy Markdown
Member

#7958 renamed _shorten_call_id to _shorten_id in openai_utils, but the thunderphone plugin and its tests still import the old name. The import fails, so type-check and unit-tests fail on main and on every PR that merges with it.

The behavior is unchanged: _shorten_id keeps the same 32-char cap and SHA-256 fallback, so thunderphone's call-id mapping still matches.

Initial prompt and agent context

Model: Claude Opus 5.5

Open a small draft fix PR against livekit/agents main. Main is broken right now.

What broke: #7958 ("fix(realtime): keep item ids within OpenAI's 32-char limit", commit 0737686, merged 2026-10-28 21:42 UTC) renamed _shorten_call_id to _shorten_id in livekit-agents/livekit/agents/llm/_realtime/openai_utils.py. It did not update the thunderphone plugin, which still imports the old name:

  • livekit-plugins/livekit-plugins-thunderphone/livekit/plugins/thunderphone/realtime/realtime_model.py:49: from livekit.agents.llm._realtime.openai_utils import _shorten_call_id
  • the same file, line 425: self._tp_call_ids[_shorten_call_id(call_id)] = call_id

Effect: main's own tests run for #7958 failed. type-check (3.10), type-check (3.13) and unit-tests fail with Module "livekit.agents.llm._realtime.openai_utils" has no attribute "_shorten_call_id" and ImportError while importing test module tests/test_plugin_thunderphone_realtime.py. Every open PR that merges with main fails the same way, for example #6202.

Task:

  1. Read the repo's AGENTS.md / CLAUDE.md first.
  2. Check that _shorten_id does the same thing for thunderphone's call ids as the old _shorten_call_id did (read fix(realtime): keep item ids within OpenAI's 32-char limit #7958's diff). If the semantics changed (for example, a different id format or length), say so before you change anything.
  3. Update the thunderphone plugin to use _shorten_id. Check the whole repo for any other _shorten_call_id reference.
  4. Run the thunderphone tests (tests/test_plugin_thunderphone_realtime.py), ruff, and the repo type check for that plugin.
  5. Commit, push, and open a draft PR with the pr-desc skill. Title like fix(thunderphone): use _shorten_id after the openai_utils rename. Reference fix(realtime): keep item ids within OpenAI's 32-char limit #7958 as the cause. This is a small fix with no Linear ticket. Apply the review-effort label per pr-desc (likely review_effort:low).
  6. Do not comment on fix(realtime): keep item ids within OpenAI's 32-char limit #7958 or any other PR, and do not request reviewers.

Report the PR link, the head SHA, and the check results.

Follow-up: "make sure there is no PR for this already"

#7958 renamed _shorten_call_id to _shorten_id in
openai_utils but did not update the thunderphone plugin or its tests.
The import fails, so type-check and unit-tests fail on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chenghao-mou
chenghao-mou marked this pull request as ready for review October 28, 2026 23:35
@chenghao-mou
chenghao-mou requested a review from a team as a code owner October 28, 2026 23:36

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@chenghao-mou
chenghao-mou merged commit d34f7e1 into main Oct 29, 2026
26 of 27 checks passed
@chenghao-mou
chenghao-mou deleted the chenghao/fix/thunderphone-shorten-id branch October 29, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants