Repository navigation
fix(e2ee): track the local encryption state separately from remote participants - #2245
Conversation
…rticipants Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 22187c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…ticipantCryptorEnabled Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
There was a problem hiding this comment.
Devin Review found 2 potential issues.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| if (!localEncryptionEnabled) { | ||
| this.appendFrameMetadata(encodedFrame); | ||
| return controller.enqueue(encodedFrame); |
There was a problem hiding this comment.
🟥 Shared worker exposes encrypted media
When rooms share a worker, localEncryptionEnabled lets one room disable encryption for every sender. An E2EE-enabled room then sends its media in plaintext.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
One worker serves one room. Sharing a worker between rooms is not supported, and that was the case before this change. The worker option now documents it.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
| ); | ||
| return; | ||
| } | ||
| if (!localEncryptionEnabled) { |
There was a problem hiding this comment.
This should mitigate the risk now.
The worker now keeps the encryption state of the local participant apart from the state of remote participants, and uses separate cryptors for senders and receivers.
Covered by unit tests in
src/e2ee/worker.🤖 Generated with Claude Code