Repository navigation
livekit-protocol: remove FunctionCall.extra, check every livekit-agents release - #942
Merged
Merged
Conversation
theomonnom
requested review from
changt,
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
November 14, 2026 01:04
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
davidzhao
approved these changes
Nov 14, 2026
Comment on lines
+18
to
+56
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7 | ||
| with: | ||
| submodules: true | ||
|
|
||
| - uses: astral-sh/setup-uv@20cfd1bf945f4377ade1205e4dbc17946fc9a30d # v10.0.1 | ||
| with: | ||
| python-version: "3.12" | ||
|
|
||
| - name: Build livekit-protocol | ||
| run: uv build --wheel livekit-protocol -o dist | ||
|
|
||
| - name: Encode a session history with every livekit-agents release | ||
| run: | | ||
| set -euo pipefail | ||
| wheel=$(ls dist/livekit_protocol-*.whl) | ||
| case "$(basename "$wheel")" in | ||
| livekit_protocol-1.*) ;; | ||
| *) echo "livekit-protocol 2+ cannot reach livekit-agents 1.x"; exit 0 ;; | ||
| esac | ||
| versions=$(curl -sf https://pypi.org/pypi/livekit-agents/json | uvx --with packaging python -c ' | ||
| import json, sys | ||
| from packaging.version import Version | ||
| releases = json.load(sys.stdin)["releases"] | ||
| print(" ".join(v for v in sorted(releases, key=Version) | ||
| if releases[v] and not Version(v).is_prerelease | ||
| and Version("1.7.0") <= Version(v) < Version("2")))') | ||
| failed="" | ||
| for v in $versions; do | ||
| uv venv -q --allow-existing "venv-$v" | ||
| VIRTUAL_ENV="venv-$v" uv pip install -q "livekit-agents==$v" | ||
| VIRTUAL_ENV="venv-$v" uv pip install -q --no-deps --reinstall "$wheel" | ||
| "venv-$v/bin/python" tests/protocol/regression_agents_session_history.py || failed="$failed $v" | ||
| done | ||
| if [ -n "$failed" ]; then | ||
| echo "::error::livekit-agents releases that cannot encode a session history:$failed" | ||
| exit 1 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.