Repository navigation
livekit-ffi: re-baseline the iOS and Android size budgets - #1623
Merged
Merged
Conversation
The 0.13.3 packages failed both size gates once the signaling client joined core-modules: iOS 1926 KiB against 1600, Android 2145 KiB against 1728. Measured locally, signaling accounts for ~443 KiB (iOS) and ~554 KiB (Android) of that; everything else since 0.13.2 adds ~35 KiB. Both limits are re-baselined with 10% headroom rounded up to 64 KiB, as in #1414: iOS 2176 KiB, Android 2368 KiB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Changeset ✓This PR includes a changeset covering all affected packages:
|
Contributor
|
fyi @xianshijing-lk we're slowly exceeding the recent native (swift) cuts ✂️ |
Contributor
Author
|
#1631 decreased the overall payload size, however it's still about the old limit, will merge this regardless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.13.3 Swift and Android packages were not published, because both size gates failed in the "UniFFI packages" run for
livekit-ffi/v0.13.3. The iOSios-arm64framework binary is 1926 KiB, against a limit of 1600 KiB. The Androidarm64-v8a.sois 2145 KiB, against a limit of 1728 KiB. The growth comes from the signaling client (#1521), which joinedcore-modulesin 0.13.3. Swift and Android cannot use the signaling client until a package with it is published.Change
Both budgets are re-baselined on the measured 0.13.3 sizes, with 10% headroom rounded up to 64 KiB, as in #1414.
SPM_SIZE_LIMIT_BYTESgoes to 2176 KiB, andANDROID_SIZE_LIMIT_BYTESgoes to 2368 KiB. Each comment records its baseline. The changeset bumpslivekit-ffias a patch, so the next release has the new budgets and can publish both packages.Verified
I built the release slices locally with the same flags as CI:
--no-default-features --features core-modules, andcargo ndkwith-C force-unwind-tables=nofor Android..solivekit-ffi/v0.13.2mainwithout the signaling modulemainmainsizes match the CI run to within 0.1%.cargo bloat --crateson iOS shows that the code section grows by 266 KiB. The largest parts arelivekit_signaling(81 KiB),urlwithidnaandicu_normalizer(49 KiB),std(34 KiB) andlivekit_protocol(21 KiB). The rest of the growth is data and unwind tables.livekit-signalingenables the tokio featuresnet,signalandio-utilbut does not use them. Removing them saved less than 1 KiB on iOS and 13 KiB on Android, so this PR does not change them.Not done yet
urlbrings in the Unicode IDNA tables. Pinningidna_adapterto its ASCII-only version can remove part of this cost, but it changes how non-ASCII hostnames parse. I did not measure it.🤖 Generated with Claude Code