Repository navigation
Experiment with read retries to handle BufferUnderflowExceptions. - #132
Merged
Merged
Conversation
Member
Author
|
According to @courtney-whalen large model training completed after this change. |
Contributor
|
Yeah, tested it out several times and haven't gotten a BufferUnderflowException again |
metasim
commented
Jun 6, 2019
| // result | ||
| // } | ||
|
|
||
|
|
Member
Author
There was a problem hiding this comment.
Sorry about that comment block. Will get rid of eventually.
metasim
commented
Jun 6, 2019
| _delRef = newDel | ||
| result | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
This is the tricky bit. Need to make sure it's thread safe, even though multiple threads "shouldn't" be calling the read code.
Member
|
@metasim did it finally work? |
Member
Author
|
@pomadchin Not sure yet.... takes a larger deployment process and several hours of training to be absolutely sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #131