Repository navigation
Conversation
…padding and version - Add SELFSYNC_ADMIN_DEVICE_LIMIT (1-1000) and SELFSYNC_ADMIN_DEVICE_APPROVAL (0/1). When set, they are written to the settings table on startup and logged at INFO; when unset, the stored value is left untouched. - Document both variables in README.md and README.zh-CN.md. - admin.html: `.wrap` padding overrode `main` padding, leaving the first card flush against the header. Use `main.wrap` so the top/bottom padding applies. - admin.html: Add selfsync version to Admin UI - Emit server version in INFO on startup - Bump versions to v0.2.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(server): seed device settings from env vars, fix admin page top padding and version
.wrappadding overrodemainpadding, leaving the first card flush against the header. Usemain.wrapso the top/bottom padding applies.Hi @loyalpartner Lee 👋,
New feature testing
I did some testing of #16. Things seem to be working more or less as you described. There is only so much I can do locally until you publish #16 to a tag so that the
ghcr.io/loyalpartner/selfsyncimage is published for this version.Important
In this commit I have pushed version tags to
v0.2.1and added an INFO logging message to print selfsync version on startup as well as display in the Admin UI. Please note to update your package versions inCargo.tomlfiles and LazyCatpackage.ymlso correct version is emitted.If you are happy with this commit, you can just tag it with
v0.2.1and hopefully it will publish to the GitHub container registry/repository. I will upgrade my production server once complete.Admin configuration via env variables
Given I deploy my selfsync server in Kubernetes, configuring the server settings via ENV variables is convenient. I've added
SELFSYNC_ADMIN_DEVICE_LIMITandSELFSYNC_ADMIN_DEVICE_APPROVALto override the settings on startup to the desired values. Updated README files to reflect behavior.Version logging and UI
Setting values via environment will emit log events that it has occurred:
The selfsync version is rendered in the header, I also standardised div spacing for the top segment:

Please review let me know if you want me to change anything in the commit or feel free to change by yourself.
Kind regards,
Berg