Repository navigation
Fix FilterForm showing added filters in arbitrary order - #11406
Merged
Merged
Conversation
fzaninotto
approved these changes
Oct 16, 2026
Member
|
Awesome, thanks for taking the time to address this long-standing issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The “Add filter” button displays a newly selected filter in its original JSX position, not after the filters the user already added. This reproduces #9225.
Solution
Render visible filters in
displayedFiltersinsertion order, while keeping always-on and value-only filters ahead of the user-added filters. The persisteddisplayedFiltersobject and list controller remain unchanged, so existing URL and saved-query data retain their format. This is narrower than the earlier, closed #9281 proposal, which changed the underlying state structure.How To Test
corepack yarn test-unit-ci packages/ra-ui-materialui/src/list/: 24 suites, 222 tests passed.corepack yarn workspace ra-core buildandcorepack yarn tsc --noEmit --project packages/ra-ui-materialui/tsconfig.json: passed.git diff --check: passed.Additional Checks
masterfor a bug fix.Closes #9225.