Repository navigation
build(deps): bump dompurify and handlebars - #11424
Merged
Merged
Conversation
- dompurify 3.4.16 -> 3.4.17 (GHSA-cg2g-xh64-v4q7, SAFE_FOR_TEMPLATES bypass through attached shadow roots). dompurify is a runtime dependency of ra-ui-materialui, so the range is raised to ^3.4.17 to make sure consumers get the patched version too. - lerna 10.0.1 -> 10.1.1, which pins handlebars 4.7.10 instead of 4.7.9 (GHSA-p8wg-vrv2-v86f, GHSA-8r5x-fm3f-whwj: prototype deny-list bypass and AST type confusion). Bumping lerna avoids carrying a yarn resolution for a transitive dev dependency. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TFj4Pu8BhJfsAPUz8va8Mw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dependabot reports 3 open critical advisories on two packages:
dompurifySAFE_FOR_TEMPLATESbypass through attached shadow rootshandlebarsFunctionconstructor reachable despite the prototype deny listhandlebarscompile()Neither is exploitable in react-admin as it stands:
RichTextFieldis the onlydompurifycaller, and it sanitizes withoutSAFE_FOR_TEMPLATES,IN_PLACEorRETURN_DOM, which are the preconditions of the bypass.handlebarsis only a transitive dev dependency, pinned bylerna, which never compiles a template coming from untrusted input.The advisories should still be cleared so the alerts stop masking real ones, and so consumers of
ra-ui-materialuiget the patcheddompurify.Solution
dompurify3.4.16 → 3.4.17. The range inra-ui-materialuiis raised from^3.2.4to^3.4.17, so that consumers resolve the patched version rather than only our lockfile.lerna10.0.1 → 10.1.1, which pinshandlebars4.7.10 instead of 4.7.9. Bumping lerna avoids carrying aresolutionsentry for a transitive dev dependency. Note that this minor lerna bump carries major bumps of its npm internals (@npmcli/arborist9 → 10,libnpmaccess10 → 11,libnpmpublish11 → 12,npm-packlist10 → 11), which is why the lockfile diff is large — that code path islerna publish.No source change, so no new test or story.
How To Test
yarn why handlebarsshould report 4.7.10, andyarn why dompurify3.4.17.As the lerna bump touches the release tooling, a
lerna publish --dry-runby someone holding publish rights would be worth doing before merging.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureRichTextFieldsuite covers thedompurifyusageGenerated by Claude Code