Repository navigation
[Chore] Update pre-commit hook to fail on ESLint warnings - #11445
Merged
Merged
Conversation
1 of 3 tasks
ThieryMichel
approved these changes
Nov 12, 2026
ThieryMichel
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pre-commit hook runs
eslint --fixon staged files, which only fails on errors. A warning (e.g. an unused import) doesn't block the commit.Solution
--max-warnings 0in.lintstagedrc, so the hook also fails on warnings.--no-warn-ignored, otherwise committing a file ignored by ESLint (e.g. acreate-react-admintemplate) fails because of the "File ignored" warning.yarn lintdoesn't:slugifyfunction indocs/js/ra-navigation.jsindexargument in thereplace-Datagrid-DataTable-Propscodemod fixturesHow To Test
import { join } from 'path';), stage it and commit: the commit is rejected withESLint found too many warnings (maximum: 0).packages/create-react-admin/templates/common/src/Layout.tsx) and commit: the commit succeeds.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature