Repository navigation
fix: patch h2 and rustls security advisories - #98
Conversation
|
@codex review Please review the exact PR head for #90, including the focused lockfile changes, retained audit exemptions, and compatibility. Local cargo-audit reports zero vulnerabilities; native Linux and Apple Silicon exemption reachability checks pass. The manual audit workflow and the remaining quality gates are running. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mateu
left a comment
There was a problem hiding this comment.
Independent Codex review of bc65d90: no actionable findings. The diff changes only the h2/rustls versions and corresponding registry checksums, preserves their dependency lists and all audit exemptions, and selects the advisory-patched compatible releases. Local audit/exemption checks and all-feature Clippy have passed. Workspace/manual CI completion remains a merge gate; this code review does not claim those still-running checks have finished.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc65d905d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the h2 regression finding by locking h2 0.4.17, which includes upstream hyperium/h2#940. The final diff still changes only h2/rustls versions and checksums; all existing advisory exemptions remain unchanged. Please review the updated head. The candidate's audit and quality gates are rerunning before merge. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The scheduled security audit failed because the native dependency graph still included vulnerable
h2 0.4.15andrustls 0.23.43. Update only their locked versions and checksums to compatible patched releases,h2 0.4.17andrustls 0.23.45.Closes #90. Part of #89.
Dependency scope
h2paths include Hyper/Axum for the MCP service, Reqwest for HTTP clients, and SurrealDB's Tonic transport.rustlsis reached through Reqwest 0.13/Hyper-Rustls and the RMCP HTTP client.Validation
287d8ea4c2a19c6a63bd570bdfd9f4e5e7c1abe8passes local cargo-audit 0.22.2 with zero vulnerabilities and only the existing two allowed unmaintained warnings; exemption checks pass for Linux x86_64 and Apple Silicon macOS.Local builds and fixtures use a separate worktree and private build/runspace. Production service and corpus are untouched.