Skip to content

fix: patch h2 and rustls security advisories - #98

Merged
mateu merged 2 commits into
mainfrom
codex/90-dependency-audit
Oct 6, 2026
Merged

mateu merged 2 commits into
mainfrom
codex/90-dependency-audit

Conversation

@mateu

@mateu mateu commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

The scheduled security audit failed because the native dependency graph still included vulnerable h2 0.4.15 and rustls 0.23.43. Update only their locked versions and checksums to compatible patched releases, h2 0.4.17 and rustls 0.23.45.

Closes #90. Part of #89.

Dependency scope

  • Fixes RUSTSEC-2026-0258 and RUSTSEC-2026-0285. Existing scoped exemptions are unchanged; no new advisories are ignored.
  • Selects h2 0.4.17 to include the upstream fix for the legitimate concurrent-small-body traffic regression introduced by the first security patch in 0.4.16. This addresses the Codex review finding.
  • Native h2 paths include Hyper/Axum for the MCP service, Reqwest for HTTP clients, and SurrealDB's Tonic transport. rustls is reached through Reqwest 0.13/Hyper-Rustls and the RMCP HTTP client.
  • Exposure depends on the actual transport and peer: the deployed service uses loopback plus an SSH tunnel, and TLS client exposure depends on HTTPS endpoints. Dependency reachability alone does not establish an exploitable deployment. The h2 advisory concerns resource exhaustion from empty HTTP/2 DATA frames; the rustls advisory concerns TLS 1.3 handshake encryption boundaries and retains transcript authentication.
  • The patched crates declare Rust 1.63 and 1.71 respectively, below the workspace's Rust 1.97.1 requirement. No manifest or application changes are needed.

Validation

  • Final candidate 287d8ea4c2a19c6a63bd570bdfd9f4e5e7c1abe8 passes local cargo-audit 0.22.2 with zero vulnerabilities and only the existing two allowed unmaintained warnings; exemption checks pass for Linux x86_64 and Apple Silicon macOS.
  • All-feature Clippy with warnings denied and workspace tests pass: 744 passed, zero failures, five existing ignored tests. The full suite includes fresh/upgrade migrations, source idempotency, resumable embedding fault injection, portable backup/reindex round-trip, and the committed retrieval baseline.
  • The deterministic daily workflow passes with isolated provider doubles and a fresh private corpus.
  • The manual scheduled-audit-equivalent run passes the dependency audit on the final head. Remaining normal CI jobs must finish green before merge.
  • The second GitHub Codex review completed without new findings; the original h2 regression thread is resolved.
  • Formatting and offline installer/release/script tests pass (16 release tests; 44 script tests, one existing skip); those files are unchanged by the review fix.

Local builds and fixtures use a separate worktree and private build/runspace. Production service and corpus are untouched.

@mateu

mateu commented Oct 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Please review the exact PR head for #90, including the focused lockfile changes, retained audit exemptions, and compatibility. Local cargo-audit reports zero vulnerabilities; native Linux and Apple Silicon exemption reachability checks pass. The manual audit workflow and the remaining quality gates are running.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T03:50:59.983612Z 287d8ea Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mateu mateu left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent Codex review of bc65d90: no actionable findings. The diff changes only the h2/rustls versions and corresponding registry checksums, preserves their dependency lists and all audit exemptions, and selects the advisory-patched compatible releases. Local audit/exemption checks and all-feature Clippy have passed. Workspace/manual CI completion remains a merge gate; this code review does not claim those still-running checks have finished.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc65d905d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.lock Resolved
@mateu

mateu commented Oct 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Addressed the h2 regression finding by locking h2 0.4.17, which includes upstream hyperium/h2#940. The final diff still changes only h2/rustls versions and checksums; all existing advisory exemptions remain unchanged. Please review the updated head. The candidate's audit and quality gates are rerunning before merge.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 287d8ea4c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mateu
mateu merged commit d7b97b9 into main Oct 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[maintenance] Patch h2 and rustls and restore the dependency audit

1 participant