Repository navigation
fix(web): keep the default instance's draft model off custom instances - #13
Closed
matthias-scale wants to merge 1 commit into
Closed
matthias-scale wants to merge 1 commit into
matthias-scale wants to merge 1 commit into
Conversation
A custom provider instance with no draft of its own fell back to the draft stored under its driver kind, which belongs to the default instance. Only Antigravity was exempt. An OpenCode instance limited to one provider (for example a Kimi-only instance) then showed a model from the default OpenCode instance: same label, but a slug missing from its own catalog. The composer treated it as unavailable, hid the reasoning control, and would have sent the foreign slug to that instance's server. Apply the default-instance check to every driver.
Owner
Author
|
Superseded by upstream pingdotgg#25511 (same commit). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
An OpenCode provider instance limited to one provider (here a Kimi-only instance,
kimi_api) could show a model from the defaultopencodeinstance. Both lists have a "Kimi K3.1 Pro", so it looked right. But the slug wasopencode-go/kimi-k3.1-pro, which is not in the Kimi instance's list.The result:
TraitsPicker.getSelectedTraits.Why
deriveEffectiveComposerModelStatefalls back to the draft saved under the driver kind (modelSelectionByProvider["opencode"]) when the selected instance has none. Those driver-keyed drafts are older than instances and belong to the default instance. Only Antigravity skipped the fallback for custom instances.Fix
Use the default-instance check for every driver. A custom instance with no draft now falls through to its own default model.
Evidence
keeps the default instance's draft model off a custom instance of the same driver: fails before the fix, passes after.apps/web: 4125 tests pass;tsc --noEmitpasses;vp fmtandvp lintare clean.kimi_apiOpenCode server reports variants fork3.1-pro(low/high/max), and T3's server catalog passes them on, so the server side was fine.