Skip to content

Fix new build system compatiblity - #922

Closed
sebikaplun wants to merge 2 commits into
meta:masterfrom
sebikaplun:fix_xcode_10
Closed

sebikaplun wants to merge 2 commits into
meta:masterfrom
sebikaplun:fix_xcode_10

Conversation

@sebikaplun

Copy link
Copy Markdown

This issue
#920

was being caused because the podspec includes all files, so the Info.plist was also being imported and the XCode warned that 2 info.plist were added the the project.

This PR excludes the plist file

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@alickbass

Copy link
Copy Markdown
Contributor

Thanks a lot for submitting this PR!

@facebook-github-bot facebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alickbass is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alickbass has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants