Repository navigation
fix: handle null package name in WearableService.handleServiceRequest - #3950
Open
sezginkipel wants to merge 1 commit into
Open
sezginkipel wants to merge 1 commit into
sezginkipel wants to merge 1 commit into
Conversation
Fixes microg#2843 Signed-off-by: Sezgin Kipel <1444sezgin@gmail.com>
|
ai slop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The
WearableService.handleServiceRequestmethod assumed thatGetServiceRequest.packageNameis always non‑null. When a request with a null package name is received,PackageUtils.getAndCheckCallingPackagethrows aNullPointerException, causing the service to crash.Key Changes
request.packageNameand defaulted it to the service’s own package name before validation.WearableServiceTestthat verifies the method works correctly with a null package name and that the callback is invoked with a success status.Verification
CommonStatusCodes.SUCCESS.Fixes #2843
Files Changed
play-services-wearable/core/src/main/java/org/microg/gms/wearable/WearableService.java,play-services-wearable/core/src/test/java/org/microg/gms/wearable/WearableServiceTest.java/claim #2843