Repository navigation
Dump the fingerprint if the targets at least match for read scenarios - #124
Merged
Merged
Conversation
David Federman (dfederm)
force-pushed
the
dfederm/dump-fingerprint-more
branch
from
March 14, 2025 23:58
b447c5e to
d9162fd
Compare
David Federman (dfederm)
force-pushed
the
dfederm/dump-fingerprint-more
branch
from
March 15, 2025 00:00
d9162fd to
33b285f
Compare
David Federman (dfederm)
enabled auto-merge (squash)
March 15, 2025 00:00
Andy Gerlicher (AndyGerlicher)
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dump the fingerprint if the targets at least match for read scenarios
This will help with debugging cache misses as the fingerprint will be dumped in more cases.
Specifically, we use a looser targets check when doing a cache lookup than we do when adding to the cache. This is to allow for better cache hits even when extra target results are given. However, previously when determining whether we should dump a fingerprint, we would only do it if the targets matched enough for adding to the cache. This change checks if the targets match for read scenarios and if so, dumps the fingerprint.