GitHubRepositories: Add Get/Set/Remove GitHub Repository Team Permissions by X-Guardian · Pull Request #300 · microsoft/PowerShellForGitHub

Simon Heather (X-Guardian) · 2020-11-07T15:34:21Z

Description

This PR adds the following functions to the GitHubRepositories module:

Get-GitHubRepositoryTeamPermission
Set-GitHubRepositoryTeamPermission
Remove-GitHubRepositoryTeamPermission

Issues Fixed

Resolves #307

References

Checklist

Howard Wolosky (HowardWolosky) · 2020-11-16T18:12:21Z

Welcome back to the project, Simon Heather (@X-Guardian)! Apologies in the delay in getting these two PR's reviewed. Things have been a bit busy for me with my primary work. I promise to get to both of these PR's within the next few days though. Thanks again for your contributions!

Howard Wolosky (HowardWolosky)

Thanks so much for this contribution, Simon Heather (@X-Guardian) (and my sincere apologies on the delayed review...I'll blame it on the holidays).

By and large this change looks great. The majority of the requests are just formatting the GitHub noun of "Team" to have a capital 'T' as opposed to a lower-case 't'.

The one design choice that I'm confused by however is the creation of your own return object in lieu of the GitHub object for Get-*. My inclination is to use the object that GitHub is returning, and add to it any additional information we think that the user might need....

Howard Wolosky (HowardWolosky) · 2020-12-02T00:26:30Z

/azp run PowerShellForGitHub-CI

azure-pipelines · 2020-12-02T00:26:44Z

Azure Pipelines successfully started running 1 pipeline(s).

Howard Wolosky (HowardWolosky) · 2020-12-02T00:28:49Z

Regarding the Team capitalization...feel free to ignore all of those requests. I just re-read through their documentation, and GitHub doesn't capitalize their nouns, so I don't feel that we need to either.

Simon Heather (X-Guardian)

Howard Wolosky (@HowardWolosky), ready for the next review.

Howard Wolosky (HowardWolosky)

Update looks good. Thanks for the quick turnaround.
Two small nits that I can apply myself once the review is submitted.
Will kick off a new pipeline build for verification now.

Thanks again!

Howard Wolosky (HowardWolosky) · 2020-12-06T02:01:02Z

/azp run PowerShellForGitHub-CI

azure-pipelines · 2020-12-06T02:01:19Z

Azure Pipelines successfully started running 1 pipeline(s).

Howard Wolosky (HowardWolosky) · 2020-12-06T16:23:41Z

/azp run PowerShellForGitHub-CI

azure-pipelines · 2020-12-06T16:24:10Z

Azure Pipelines successfully started running 1 pipeline(s).

Howard Wolosky (HowardWolosky) · 2020-12-06T16:26:40Z

Simon Heather (@X-Guardian) -- Can you resolve these conflicts locally to avoid the line ending changes that the web editor causes?

Simon Heather (X-Guardian) · 2020-12-07T00:21:31Z

Howard Wolosky (@HowardWolosky), conflicts resolved. Ready for the next review.

Simon Heather (X-Guardian) · 2020-12-17T17:19:36Z

Howard Wolosky (@HowardWolosky), any update on getting this PR merged?

Howard Wolosky (HowardWolosky) · 2020-12-18T04:02:17Z

My apologies. Will get to this tomorrow. I had started looking at it earlier, but I think the rebase threw me off, as I was getting confused why tests were being deleted as part of the updates, and needed to devote more time to re-reviewing the whole thing.

Howard Wolosky (HowardWolosky) · 2020-12-21T15:39:14Z

This is actually queued for review again this afternoon. Thanks for your patience.

Howard Wolosky (HowardWolosky)

So very sorry for the delayed PR on this update. Holiday time has been pretty busy for me over here. Still, I should have communicated a bit better on this. Again, my apologies.

Your contributions, as always, are very much appreciated.

A few updates to this are being requested. Almost all of them have suggested changes that you can simply apply.

The main question that I have here (and I can't recall if I had the same concern the last time) is whether or not we need OrganizationName as an additional parameter to these methods, or if we can just re-use OwnerName as the OrganizationName as well. Do you know if it's possible for an organization's team to be given permission to an individual person's repo ? (I don't think you can).

Howard Wolosky (HowardWolosky) · 2020-12-22T02:55:04Z

+            ValueFromPipelineByPropertyName,
+            ParameterSetName = 'TeamSlugUri')]
+        [ValidateNotNullOrEmpty()]
+        [string] $OrganizationName,


Same question as above.

Howard Wolosky (HowardWolosky)

All the updates here look good. Given our conversation around OrganizationName, I'll await a final update that removes OrganizationName and just has it reuse the OwnerName for both OwnerName and OrganizationName. Thanks again.

Simon Heather (X-Guardian) · 2020-12-24T08:27:13Z

Howard Wolosky (@HowardWolosky), I've removed the OrganizationName parameter, so the PR is ready for the next review.

Howard Wolosky (HowardWolosky)

This update looks good. Will kick off a pipeline and then merge upon completion.
Thanks!

Howard Wolosky (HowardWolosky) · 2020-12-24T18:46:50Z

/azp run PowerShellForGitHub-CI

azure-pipelines · 2020-12-24T18:47:03Z

Azure Pipelines successfully started running 1 pipeline(s).

Simon Heather (X-Guardian) · 2020-12-27T10:22:19Z

Howard Wolosky (@HowardWolosky), thankyou for merging this. Do you have any plans for releasing a new version?

Howard Wolosky (HowardWolosky) · 2020-12-31T23:12:14Z

thankyou for merging this. Do you have any plans for releasing a new version?

I'll get the next version released tomorrow or this weekend.

Howard Wolosky (HowardWolosky) · 2021-01-05T20:06:01Z

I'll get the next version released tomorrow or this weekend.

Had a slight delay, but it's now published. Thanks again for your help here!

Simon Heather (X-Guardian) · 2021-01-05T21:47:56Z

No problem, thanks Howard.

Simon Heather (X-Guardian) marked this pull request as draft November 7, 2020 15:35

Simon Heather (X-Guardian) marked this pull request as ready for review November 7, 2020 15:41

Howard Wolosky (HowardWolosky) added api completeness This is basic API functionality that hasn't been implemented yet. api-repositories Work to complete the API's defined here: https://developer.github.com/v3/repos/ labels Nov 8, 2020

Howard Wolosky (HowardWolosky) self-assigned this Nov 8, 2020

Howard Wolosky (HowardWolosky) suggested changes Dec 2, 2020

View reviewed changes

ghost added the needs-author-feedback label Dec 2, 2020

Howard Wolosky (HowardWolosky) mentioned this pull request Dec 2, 2020

GitHubRepositories: Add Get/Set GitHub Repository Actions Permissions #301

Merged

10 tasks done

ghost removed the needs-author-feedback label Dec 5, 2020

Simon Heather (X-Guardian) commented Dec 5, 2020

View reviewed changes

Howard Wolosky (HowardWolosky) previously approved these changes Dec 6, 2020

View reviewed changes

Comment thread GitHubRepositories.ps1 Resolved

Comment thread GitHubRepositories.ps1 Resolved

Howard Wolosky (HowardWolosky) dismissed their stale review via 6f578ad December 6, 2020 02:00

Simon Heather (X-Guardian) and others added 7 commits December 6, 2020 23:54

Initial commit

3acc801

Move repositoryAcceptHeader to Core

b0b669e

Add pipeline tests

8c855bd

fixed review comments

81eddf3

Update GitHubRepositories.ps1

f1e8cd3

Rebase from master

0888e0e

Fix merge issues

b8ca451

Howard Wolosky (HowardWolosky) suggested changes Dec 22, 2020

View reviewed changes

ghost added the needs-author-feedback label Dec 22, 2020

Fix review comments

28a1c66

ghost removed the needs-author-feedback label Dec 22, 2020

Merge branch 'master' into GitHubRepositories-Team-Permissions

4917462

Howard Wolosky (HowardWolosky) suggested changes Dec 22, 2020

View reviewed changes

ghost added the needs-author-feedback label Dec 22, 2020

Howard Wolosky (HowardWolosky) mentioned this pull request Dec 23, 2020

Add Teams to Repo #307

Closed

Remove Organization parameter

8978814

ghost removed the needs-author-feedback label Dec 24, 2020

Howard Wolosky (HowardWolosky) approved these changes Dec 24, 2020

View reviewed changes

Howard Wolosky (HowardWolosky) merged commit 22e3d7b into microsoft:master Dec 24, 2020

Simon Heather (X-Guardian) deleted the GitHubRepositories-Team-Permissions branch December 27, 2020 10:21

Howard Wolosky (HowardWolosky) mentioned this pull request Jul 26, 2022

Get-GitHubRepositoryTeamPermission incorrectly reports push permission when maintain is available #360

Closed

Howard Wolosky (HowardWolosky) mentioned this pull request Feb 27, 2023

API Coverage: Add Support for Deployment Environments #395

Merged

9 of 10 tasks

Conversation

Simon Heather (X-Guardian) commented Nov 7, 2020 • edited by HowardWolosky Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Fixed

References

Checklist

Uh oh!

Howard Wolosky (HowardWolosky) commented Nov 16, 2020

Uh oh!

Howard Wolosky (HowardWolosky) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Howard Wolosky (HowardWolosky) commented Dec 2, 2020

Uh oh!

azure-pipelines Bot commented Dec 2, 2020

Uh oh!

Howard Wolosky (HowardWolosky) commented Dec 2, 2020

Uh oh!

Simon Heather (X-Guardian) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Howard Wolosky (HowardWolosky) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Howard Wolosky (HowardWolosky) commented Dec 6, 2020

Uh oh!

azure-pipelines Bot commented Dec 6, 2020

Uh oh!

Howard Wolosky (HowardWolosky) commented Dec 6, 2020

Uh oh!

azure-pipelines Bot commented Dec 6, 2020

Uh oh!

Howard Wolosky (HowardWolosky) commented Dec 6, 2020

Uh oh!

Simon Heather (X-Guardian) commented Dec 7, 2020

Uh oh!

Simon Heather (X-Guardian) commented Dec 17, 2020

Uh oh!

Howard Wolosky (HowardWolosky) commented Dec 18, 2020

Uh oh!

Howard Wolosky (HowardWolosky) commented Dec 21, 2020

Uh oh!

Howard Wolosky (HowardWolosky) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Howard Wolosky (HowardWolosky) Dec 22, 2020

Choose a reason for hiding this comment

Uh oh!

Simon Heather (X-Guardian) Dec 24, 2020

Choose a reason for hiding this comment

Simon Heather (X-Guardian) commented Nov 7, 2020 •

edited by HowardWolosky

Loading