Skip to content

Improve error when default-importing from a module that export *s from a module with a default export #37092

Closed
#37212
Closed
Improve error when default-importing from a module that export *s from a module with a default export#37092
#37212
Labels
Domain: Error MessagesThe issue relates to error messagingExperience EnhancementNoncontroversial enhancementsFixedA PR has been merged for this issueGood First IssueWell scoped, documented and has the green lightHelp WantedYou can do this
Milestone
TypeScript 3.9.1

Description

@bluelovers
bluelovers (bluelovers)
opened on Feb 27, 2020

TypeScript Version: 3.7.x-dev.201xxxxx

Search Terms:

Code

https://github.com/bluelovers/ws-react/blob/master/packages/react-use-localstorage/index.ts

export * from './core/v4';
//import createStorageHook from './core/v4';
//export default createStorageHook

//console.log(exports.default)
import createStorageHook from './src/core';

Expected behavior:

know "src/core" has default import

Actual behavior:

Error:(2, 8) TS1192: Module '"src/core"' has no default export.

Playground Link:

Related Issues:

#37090

Activity

  1. DanielRosenwasser commented on Feb 28, 2020

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Feb 28, 2020
    Member

    export * doesn't include default exports

  2. DanielRosenwasser commented on Feb 28, 2020

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Feb 28, 2020
    Member

    That should be what this issue is - that the error message is bad. We should detect the export * and hint that an export * doesn't create a default export.

  3. Daniel Rosenwasser (DanielRosenwasser)
    added
    Domain: Error MessagesThe issue relates to error messaging
    Experience EnhancementNoncontroversial enhancements
    Good First IssueWell scoped, documented and has the green light
    Help WantedYou can do this
    on Feb 28, 2020
  4. Daniel Rosenwasser (DanielRosenwasser)
    changed the title [-]TS1192: Module '"src/core"' has no default export.[/-] [+]Improve error when default-importing from a module that `export *`s from a module with a default export[/+] on Feb 28, 2020

  5. rpgeeganage commented on Feb 29, 2020

    @rpgeeganage
    Ruwan Pradeep Geeganage (rpgeeganage)
    on Feb 29, 2020
    Contributor

    Can I take this?

  6. Daniel Rosenwasser (DanielRosenwasser)
    closed this as completedin #37212on Mar 27, 2020
  7. Daniel Rosenwasser (DanielRosenwasser)
    added this to the TypeScript 3.9.1 milestone on Mar 27, 2020

  8. DanielRosenwasser commented on Mar 27, 2020

    @DanielRosenwasser
    Daniel Rosenwasser (DanielRosenwasser)
    on Mar 27, 2020
    Member

    Sorry I missed that Ruwan Pradeep Geeganage (@rpgeeganage) - but thanks for fixing this Oleksandr Tarasiuk (@a-tarasyuk)!

  9. Daniel Rosenwasser (DanielRosenwasser)
    added
    FixedA PR has been merged for this issue
    on Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Domain: Error MessagesThe issue relates to error messagingExperience EnhancementNoncontroversial enhancementsFixedA PR has been merged for this issueGood First IssueWell scoped, documented and has the green lightHelp WantedYou can do this

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions